The renderer '#type' => 'link' does not render links to the public:// files.

Exception Uncaught e UnroutedUrlAssemb   75 Drupal\Core\Utility\UnroutedUrlAsse
    InvalidArgumentException: The URI "public://file.yml" is invalid.
    You must use a valid URI scheme. Use base:// for a path, e.g., to a Drupal
    file that needs the base path. Do not use this for internal paths controlled
    by Drupal. in Drupal\Core\Utility\UnroutedUrlAssembler->assemble() (line
    75 of
    /var/www/d8/drupal/core/lib/Drupal/Core/Utility/UnroutedUrlAssembler.php).
    Drupal\Core\Utility\UnroutedUrlAssembler->assemble('public://file.yml',
    Array)
    Drupal\Core\Url->toString()
    Drupal\Core\Utility\LinkGenerator->generate('bar', Object)
    Drupal::l('bar', Object)
    Drupal\Core\Render\Element\Link::preRenderLink(Array)
    call_user_func(Array, Array)
    Drupal\Core\Render\Renderer->doRender(Array, )
    Drupal\Core\Render\Renderer->render(Array, )
    drupal_render(Array)
    Drupal\system\Tests\Common\UrlTest->testA()
    Drupal\simpletest\TestBase->run(Array)
    simpletest_script_run_one_test('9', 'Drupal\system\Tests\Common\UrlTest')
CommentFileSizeAuthor
#13 2410681-link_public_url-9.patch1.82 KBvictor-shelepen
#9 2410681-link_public_url-8.patch976 bytesvictor-shelepen
#7 2410681-link_public_url-7.patch1.82 KBvictor-shelepen
#2 2410681-link_public_url-2.patch1.82 KBvictor-shelepen
#1 2410681-link_public_url-1.patch976 bytesvictor-shelepen
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

victor-shelepen’s picture

victor-shelepen CreditAttribution: victor-shelepen commented
FileSize
2410681-link_public_url-1.patch976 bytes

This case breaks the system.

victor-shelepen’s picture

victor-shelepen CreditAttribution: victor-shelepen commented
Status: Active » Needs review
FileSize
2410681-link_public_url-2.patch1.82 KB

It fixes the bug case.

mikran’s picture

mikran CreditAttribution: mikran commented
Project: Relation » Drupal core
Version: 8.x-1.x-dev » 8.0.x-dev
Component: API » link.module

fixing project, component is just a guess based on patch file name

victor-shelepen’s picture

victor-shelepen CreditAttribution: victor-shelepen commented
Status: Needs review » Active
victor-shelepen’s picture

victor-shelepen CreditAttribution: victor-shelepen commented
Status: Active » Needs work
victor-shelepen’s picture

victor-shelepen CreditAttribution: victor-shelepen commented
Status: Needs work » Needs review
victor-shelepen’s picture

victor-shelepen CreditAttribution: victor-shelepen commented
FileSize
2410681-link_public_url-7.patch1.82 KB

It fixes the bug case.

victor-shelepen’s picture

victor-shelepen CreditAttribution: victor-shelepen commented
victor-shelepen’s picture

victor-shelepen CreditAttribution: victor-shelepen commented
FileSize
2410681-link_public_url-8.patch976 bytes

This path fails tests. To apply a patch to fix the issue use https://www.drupal.org/node/2410681#comment-9536147 .

The last submitted patch, 2: 2410681-link_public_url-2.patch, failed testing.

The last submitted patch, 1: 2410681-link_public_url-1.patch, failed testing.

Status: Needs review » Needs work

The last submitted patch, 9: 2410681-link_public_url-8.patch, failed testing.

victor-shelepen’s picture

victor-shelepen CreditAttribution: victor-shelepen commented
Status: Needs work » Needs review
FileSize
2410681-link_public_url-9.patch1.82 KB

Fixed.

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers commented

I don't think '#type' => 'link' was ever designed to link to file URLs. I'm not sure we want that architecturally speaking, but I can see why you'd want to see that be supported.

+++ b/core/lib/Drupal/Core/Utility/UnroutedUrlAssembler.php
@@ -68,6 +68,9 @@ public function assemble($uri, array $options = []) {
+    elseif (strpos($uri, 'public://') === 0 || strpos($uri, 'private://') === 0) {

What about s3:// or custom://?

mgifford’s picture

mgifford
he/him
Primary language English
CreditAttribution: mgifford at OpenConcept Consulting Inc. commented
Status: Needs review » Needs work

No longer applies.

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented
Title: The renderer '#type' => 'link' does not render links to the public:// files. » The renderer '#type' => 'link' does not render links to the public:// files
Version: 8.0.x-dev » 8.1.x-dev
Category: Bug report » Feature request

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.0-beta1 was released on March 2, 2016, which means new developments and disruptive changes should now be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.0-beta1 was released on August 3, 2016, which means new developments and disruptive changes should now be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.0-alpha1 will be released the week of January 30, 2017, which means new developments and disruptive changes should now be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.0-alpha1 will be released the week of July 31, 2017, which means new developments and disruptive changes should now be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.