Closed (fixed)
Project:
Profile
Version:
8.x-1.x-dev
Component:
User interface
Priority:
Normal
Category:
Feature request
Assigned:
Reporter:
Created:
16 Dec 2015 at 14:26 UTC
Updated:
15 Jan 2016 at 18:23 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
subhojit777Comment #3
mglamanPR https://github.com/bojanz/profile/pull/24
Posting patch of PR.
Comment #4
mglamanYou're loading nodes here, and not saving the expected profile.
Comment #5
mglamanComment #8
mglamanHere is patch with fixes. First check to make sure entity being saved is default, load properly.
Comment #11
subhojit777Checking the failing tests.
Comment #12
subhojit777This is throwing some plugin not found exception, not sure about this error - will have to look into it.
Comment #15
mglamanWe do not need to define "default" here, because its schema is defined within base field definitions.
Comment #16
mglamanCan we try it without the postSave and see if that's the issue? Help narrow it down.
Comment #17
subhojit777Yes I tried without postSave, still getting the same error. I am trying to compare the new added with existing
statusprofile field, I am checking what we are missing.Comment #18
mglamanHere's an updated patch. Moved "default" to be "primary" since default is reserved. Tried to set default value.
Randomly on UI side clearing caches fixed it.
Comment #19
subhojit777Comment #22
subhojit777Comment #25
mglamanGiving my patch a shot, seemed to pass OK on Travis.. https://travis-ci.org/mglaman/profile/builds/98537590
Comment #26
mglamanOk, so since my patch did pass, here is interdiff.
Comment #27
mglamanFix some comment mishaps.
Comment #29
mglamanThanks for all the help, subhojit777!
Comment #31
subhojit777This produces a call to itself :p
Comment #32
mglamanAre you sure?
We're looping other other profile entities who have been marked as not default, which would miss this logic.
Comment #33
subhojit777This is working as expected. There was mistake in my code logic itself :p