Creating a new issue from the issue related here...

If you go through this workflow...

  1. Open issue, status is "active"
  2. Upload patch on issue comment, status is still "active"
  3. Whoops, forgot to set status to "needs review," add new issue comment that just changes the status

Drupal CI will not test the patch on the subsequent status change. It only seems to test patches that are uploaded on comments that also simultaneously change the status to needs review.

For an example, see this thread: https://www.drupal.org/node/2634104#comment-10664062

Comments

iamEAP created an issue. See original summary.

tr’s picture

tr commented
Related issues: +#2637316: DrupalCI doesn't respect issue Version change

I can confirm this bug. It seems related to #2637316: DrupalCI doesn't respect issue Version change - in that issue, if you post a patch and change the Version of the issue (e.g. from D8 to D7 for a backport) in the same post, DrupalCI tests against the old Version not the new.

Mixologic’s picture

Mixologic
He/Him/His
Primary language English
Location Portland, OR
commented
Project: DrupalCI: Drupal.org Testing Infrastructure » Project issue file test
Version: » 7.x-3.x-dev
Component: Code » Testing Triggers
Status: Active » Postponed (maintainer needs more info)

Im pretty sure this is no longer an issue as I've definitely uploaded patches, and forgot to mark needs review and then later switched it to needs review.

drumm’s picture

drumm
he/him
Location NY, US
commented
Status: Postponed (maintainer needs more info) » Closed (duplicate)
Related issues: +#1162082: Add a warning if a diff/patch file is selected and issue status is not testable

#1162082: Add a warning if a diff/patch file is selected and issue status is not testable