Delete old revisions then lost field collection data which is add by in old revision and even when in a field collection there is reference field(e.g. node-reference/term-reference) and suppose I delete the node/term.. then those existing revision of the field collection are basically lost, even it's(item-id) not able to update with new reference(node/taxonomy) value

CommentFileSizeAuthor
#2 field_collection-lostdata_deleting_old_revision-2634574-1-7.patch786 bytesroynilanjan

Comments

roynilanjan created an issue. See original summary.

roynilanjan’s picture

roynilanjan commented
StatusFileSize
new field_collection-lostdata_deleting_old_revision-2634574-1-7.patch786 bytes

Here is the attached patch to fix the above issue!

roynilanjan’s picture

roynilanjan commented
Status: Active » Needs review
siavash’s picture

siavash commented

Works great!! Thanks!

This should really get committed, FC revisions are practically broken at the moment.

helmo’s picture

helmo commented

Isn't this related to #2000690: Deleting revisions via node_revision_delete wrongly deletes entire field collection

renatog’s picture

renatog commented

I applied and the #2 is doing the workaround cited at https://www.drupal.org/project/field_collection/issues/1031010#comment-8...

It's working fine as we can see here and here

+1 to this. Thanks you so much for your job

  • RenatoG committed 862d94a on 7.x-1.x authored by roynilanjan 
    Issue #2634574 by roynilanjan, Siavash, helmo, RenatoG: Delete old...
renatog’s picture

renatog commented
Status: Needs review » Fixed

Moved to the dev branch

Thank you so much everyone

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.