Problem/Motivation

Follow-up to #2557119: Allow discounts to indicate compatibility with other discounts

Discounts are complicated enough problem as it is, and this compatibility feature is causing confusion for both users, and bugs in it's current implementation.
@see:
#2618072: Compatibility settings not honored with multiple coupons, allowing multiple discounts on order
#2621526: Compatibility settings other than "all" causes Discount+Coupon to be removed

Proposed resolution

Disable this feature and move it to an experimental option under the discount settings.

Remaining tasks

Write patch to hide it.

User interface changes

Removes compatibility settings by default.

API changes

Data model changes

Comments

joelpittet created an issue.

rszrama’s picture

rszrama commented

It appears to me the issue is with the way the Coupon module itself operates, not necessarily the feature in question. This proposal seems to introduce additional complexity - it would seem better to just fix the Coupon module than temporarily undo something we have to redo at a later date. : )

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented

This will cause some issues with existing deployments which are using compatibility. If the issue is Coupons then coupons needs to be fixed.

torgospizza’s picture

torgospizza
he/him
Primary language English
Location Portland, OR
commented

The issue appears to occur (at least to one tester) even without Coupons. See #2621526-28: Compatibility settings other than "all" causes Discount+Coupon to be removed

ordermind’s picture

ordermind commented

Yeah, this has nothing to do with coupons. Order discount compatibility can possibly be saved with a patch but product discount compatibilities are utterly broken. I'll see what I can do but probably we need different condition callbacks for order discounts vs product discounts in order to show correct discounts when listing products.

In any case I urge you not to remove this feature as it is quite important. We should fix it instead.

ordermind’s picture

ordermind commented

There, I've fixed it: https://www.drupal.org/node/2618072#comment-11592333