Follow-up to #2337283-50: Add a composer.json file to every component

Update the test group name in ContainerAwareEventDispatcherTest.php Annotation to EventDispatcher

CommentFileSizeAuthor
#2 eventdispatcher_test_group-2630988-2.patch621 byteshussainweb

Comments

naveenvalecha created an issue. See original summary.

hussainweb’s picture

hussainweb
Primary language English
commented
Issue summary: View changes
Priority: Minor » Normal
Status: Active » Needs review
StatusFileSize
new eventdispatcher_test_group-2630988-2.patch621 bytes

Seeing that the entire docblock for the test is not in the Symfony's version, I think it is safe to change. This might need a change in the patch in #2337283-53: Add a composer.json file to every component, if this gets in first.

naveenvalecha’s picture

naveenvalecha
He/Him
commented
Priority: Normal » Minor
Status: Needs review » Reviewed & tested by the community

Thanks for the patch!

naveenvalecha’s picture

naveenvalecha
He/Him
commented
Status: Reviewed & tested by the community » Postponed

we need to updated the group name in the TESTING.txt of the component as well if the #2337283: Add a composer.json file to every component will be committed before.

naveenvalecha’s picture

naveenvalecha
He/Him
commented
Status: Postponed » Reviewed & tested by the community

Reopening this one #2337283-65: Add a composer.json file to every component

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 81fef19 and pushed to 8.0.x and 8.1.x. Thanks!

  • alexpott committed 0f5291e on 8.1.x 
    Issue #2630988 by hussainweb, naveenvalecha: Update the test group name...

  • alexpott committed 81fef19 on 
    Issue #2630988 by hussainweb, naveenvalecha: Update the test group name...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.