Problem/Motivation

Follow-up to #2337283-50: Add a composer.json file to every component

Drupal\Tests\Component\Assertion\InspectorTest is annotated incorrectly, based on @group coding standards.

Proposed resolution

Change its @group annotation to Annotation.

Ensure that the annotation component's TESTING.txt file accurately reflects the test group.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#3 assertion_test_group-2630986-3.patch499 byteshussainweb
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

naveenvalecha created an issue. See original summary.

hussainweb’s picture

hussainweb
Primary language English
CreditAttribution: hussainweb at Axelerant commented
Issue summary: View changes

I think you meant 'Assertion'. It is already Inspector.

hussainweb’s picture

hussainweb
Primary language English
CreditAttribution: hussainweb at Axelerant commented
Status: Active » Needs review
FileSize
assertion_test_group-2630986-3.patch499 bytes

As in the other issue, the patch in #2337283-53: Add a composer.json file to every component might need updating if this goes in first.

naveenvalecha’s picture

naveenvalecha
He/Him
Primary language Hindi
CreditAttribution: naveenvalecha as a volunteer commented
Status: Needs review » Reviewed & tested by the community

Thanks for the patch!

naveenvalecha’s picture

naveenvalecha
He/Him
Primary language Hindi
CreditAttribution: naveenvalecha as a volunteer commented
Status: Reviewed & tested by the community » Postponed

we need to updated the group name in the TESTING.txt of the component as well when the #2337283: Add a composer.json file to every component will be in

Mile23’s picture

Mile23
Primary language English
Location Seattle, WA
CreditAttribution: Mile23 as a volunteer commented
Title: Update the test group name in InspectorTest.php Annotation to Inspector » Update the test group name in InspectorTest.php to Annotation
Issue summary: View changes
Status: Postponed » Reviewed & tested by the community

We don't need to postpone this. One issue or the other can do the reroll, though we must expand the scope here to make sure we cover TESTING.txt if the other one is first.

Setting RTBC, running the test again.

naveenvalecha’s picture

naveenvalecha
He/Him
Primary language Hindi
CreditAttribution: naveenvalecha as a volunteer commented

I postponed this due to #2337283-65: Add a composer.json file to every component

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Title: Update the test group name in InspectorTest.php to Annotation » Update the test group name in InspectorTest.php to Assertion
Status: Reviewed & tested by the community » Fixed

Committed ae18942 and pushed to 8.1.x. Thanks!

  • alexpott committed ae18942 on 8.1.x 
    Issue #2630986 by hussainweb: Update the test group name in...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.