Correct the join from revision data table to revision base table

Looks good to me. Test explains it all. Maybe before and after query of the test view and test only path would also help committers to understand the problem.

You mean completely broken vs. runnable?

I just read #2626166-22: Create a view for content revisions and tested #2626166-28: Create a view for content revisions. Now I know what you mean so never mind me. This will also be usable for #1863906: [PP-1] Replace content revision table with a view so marking it as a major.

Do we need an empty update hook to force a cache clear? So that sites can the new views data?

Thanks.

Still RTBC.

Still RTBC.

+++ b/core/modules/views/views.install
@@ -329,5 +329,12 @@ function views_update_8003() {
 /**
+ * Clear caches due to updated entity views data.
+ */
+function views_update_8004() {
+  // Empty update to cause a cache flush so that views data is rebuilt.
+}
+
+/**
  * @} End of "addtogroup updates-8.0.0-rc".
  */

Yep we don't need a test for a cache clear but we need an new update group... 8.0.0-rc is history :)

We've been saying that anything with an update hook should be 8.1.x but I think this is an exception since it is a bug fix with an empty update hook - therefore I think we should put it in updates-8.0.x

The core committers and Views maintainers (alexpott, xjm, effulgentsia, tim.plunkett, and dawehner) agreed that this is a major issue.

+++ b/core/modules/views/views.install
@@ -329,6 +329,15 @@ function views_update_8003() {
+ * @addtogroup updates-8.0.4

@@ -336,5 +345,5 @@ function views_update_8004() {
+ * @} End of "addtogroup updates-8.0.4".

I think @alexpott can decide whether to use 8.0.x or 8.0.4. Other then this is RTBC.

8.0.x is good - there's no guarantee this gets released as part of 8.0.4 since that could be a security release, then it'd end up being 8.0.5 - also an update defgroup every six months is plenty.

Committed/pushed to 8.1.x and cherry-picked to 8.0.x. Thanks!

@catch you only committed http://cgit.drupalcode.org/drupal/commit/?id=f9930b4 to 8.0.x instead of whole patch.

Still RTBC. We need to revert #24 and commit #20 to 8.0.x

Arrgh. Thanks jibran. Reverted the bad commit and re-committed.