Fatal error when creating taxonomy term glossary view

Thank you for the report!

At that point $this->placeholders is completly empty so I'm wondering whether we need this + ... at all.

Jiha, this solution worked very well for my needs. Is there a chance to get this solution into core?

Hi,
I have patched for Above issue as suggested solutions.
Also this issue exist in core 8.1.x

Patch is working. Thanks.

Hi,
patch re-rolled for supporting Druapl 8.1.x version

How did this become Major suddenly? Perhaps it is Major, but there was no explanation given.

A fatal affecting certain situations is Major.

So is the latest patch for 8.1.x working or not?

This bug still exists in 8.1.6. Tried it on a vanilla install on simplytest.me

Moving the work over from #2778411: Glossary mode is not working for taxonomy in views contextual filter and closing that as a duplicate.

Fix and a test. Approach os a little different for the fix. Instead of testing for this->placeholders we just throw it out, it's not used anywhere in the entire project.

Talked to @dawehner on IRC about moving the test to dedicated many-to-one tests, except we don't have any. So leaving this as a separate test for now.

This looks good. The test properly demonstrates the current fatal error.

A few tiny nits (they could potentially be fixed on commit).

1. +++ b/core/modules/views/src/Tests/TaxonomyGlossaryTest.php
   @@ -0,0 +1,63 @@
   +  public static $modules = ['taxonomy'];
   ...
   +  public static $testViews = ['test_taxonomy_glossary'];
   

   Could these use {@inheritdoc} instead?

2. +++ b/core/modules/views/src/Tests/TaxonomyGlossaryTest.php
   @@ -0,0 +1,63 @@
   +  protected function setUp() {
   +    parent::setUp();
   

   This needs the {@inheritdoc} docblock.

@jhedstrom thanks for the review!

1. Both @inheritdoc and the copy/paste string occur in core, no real consensus i guess. I like the inheritdoc here, it clearly indicates nothing special is happening.
2. Added.

Thank you

.

Committed 33280fd and pushed to 8.3.x. Thanks!

Setting to 'patch to be ported' for cherry-pick to 8.2.x once 8.2.0 is released.

I considered the BC implications of this tiny behaviour change on commit but the property is not documented or used anywhere but here and I don't think the ManyToOneHelper is an extension point.

diff --git a/core/modules/views/src/Tests/TaxonomyGlossaryTest.php b/core/modules/views/src/Tests/TaxonomyGlossaryTest.php
index 76443cc..ccda887 100644
--- a/core/modules/views/src/Tests/TaxonomyGlossaryTest.php
+++ b/core/modules/views/src/Tests/TaxonomyGlossaryTest.php
@@ -2,12 +2,7 @@
 
 namespace Drupal\views\Tests;
 
-use Drupal\Component\Utility\Unicode;
-use Drupal\Core\Language\LanguageInterface;
-use Drupal\Core\Url;
-use Drupal\taxonomy\Entity\Vocabulary;
 use Drupal\taxonomy\Tests\TaxonomyTestTrait;
-use Drupal\views\Views;
 
 /**
  * Tests glossary functionality of taxonomy views.

Fixed on commit.

I was going to ask how to apply the patch in #2630692: Fatal error when creating taxonomy term glossary view to Drupal 8.2-RC2, since it is not included in that version.
I have now done some testing, and to answer my own question, if anyone else has this issue, one way is to define Drupal core version and the patch in a make-file like this:

# Drupal core version
core: '8.x'

# Drush Make API version
api: 2

# Core project
projects:
  drupal:
    patch:
      - "https://www.drupal.org/files/issues/taxonomy_glossary-2630692-17.patch"
...

Committed 103a18d and pushed to 8.2.x. Thanks!

Awesome, thank you so much @alexpott!

Correcting issue credit.