When the metatags field is used with node entities, it makes sense to have the Metatags fieldsset appear in the "advanced" section, which usually appears on the Right-Hand-Side of the node.

I am not sure if I am the only one who thinks this way, but I will make a patch to see if you guys like it as well.

CommentFileSizeAuthor
#4 metatag-n2630068-4.patch583 bytesDamienMcKenna
#2 2630068-2-metatags_fields_in_node_advanced.patch671 bytesjaxxed
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jaxxed created an issue. See original summary.

jaxxed’s picture

jaxxed CreditAttribution: jaxxed at Wunder commented
Status: Active » Needs review
FileSize
2630068-2-metatags_fields_in_node_advanced.patch671 bytes

Here is a quick patch to the field widget (firehose) that just adds the entire metatags form elements to the node "advanced" group. If desired, I could add a quick checkbox to the widget configuration, so that the decisions about where to put the fieldset can be made per field.

A note about the implementation:

- this is accomplished by adding '#group' => 'advanced' to the widget form element.
- the node already has an "advanced" group
- if adding the field to an entity that has no advanced group, the setting is ignored (test it with user or something)

* if attaching the widget to an entity that has an advanced group, but into which it doesn't make sense to have the metatags added, then maybe we have a problem.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Status: Needs review » Needs work

I didn't do this already on purpose - the Metatag form will have so many meta tags that I thought it would be a bad UX. I'd be willing to accept this if there was a global setting controlling it, but not as-is.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Status: Needs work » Needs review
FileSize
metatag-n2630068-4.patch583 bytes

Rerolled as-is.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Assigned: jaxxed » Unassigned
Status: Needs review » Fixed
Parent issue: » #2563607: Plan for Metatag 8.x-1.0-beta4 release

Lets just go with this as-is.

  • DamienMcKenna committed 56026cc on 8.x-1.x authored by jaxxed 
    Issue #2630068 by jaxxed, DamienMcKenna: Moved the meta tags fields into...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

mvwensen’s picture

mvwensen CreditAttribution: mvwensen commented

UX follow up: #2902251: Make forcing the form field into advanced region optional