Since version 7.x-2.1, the module settings at "at Administration -> Configuration -> Content authoring -> Hide submit settings" (admin/config/content/hide-submit) are completely ignored. No matter which Blocking method has been selected, it will always be set to "Hide", and the set Processing text will *not* be displayed. This used to work fine in 7.x-2.0.

CommentFileSizeAuthor
#5 2629428_hide_submit_settings_location.patch4.95 KBgreggles

Comments

roball created an issue. See original summary.

threyes’s picture

threyes commented

i have the same problem.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented

That seems bad. Thanks for filing the bug. I wonder which commit introduced the problem. Did you try running git bisect to find out? Does this happen on a fresh install?

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented

I think I found the bug. The settings are now at Drupal.settings.hide_submit.hide_submit_hide_css but the javascript expects them at Drupal.settings.hide_submit_hide_css

Patch coming soon.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented
Status: Active » Needs review
StatusFileSize
new 2629428_hide_submit_settings_location.patch4.95 KB

  • greggles committed d2d49f1 on 7.x-2.x 
    Issue #2629428 by greggles: Module settings are ignored
greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented

I decided to commit/push this without review since this bug is pretty important.

If there's a problem with the patch it can be fixed in a followup.

Can either of you please comment to confirm this solves the problem for you? Then I'll roll a new release.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented

This change is now in https://www.drupal.org/node/1814708 if you jus twant to download the latest tarball.

roball’s picture

roball commented
Status: Needs review » Fixed

Thank you @greggles, your patch from #5 perfectly solved the problem.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.