Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.This theme fails a basic code review by the coder module and is not in compliance with Drupal code standards.
I have attached a basic coder module report below.
drush coder bootstrap
sites/all/themes/bootstrap/bootstrap.info:
+2: [normal] String concatenation should be formatted with a space separating the operators (dot .) and the surrounding terms
+3: [normal] String concatenation should be formatted with a space separating the operators (dot .) and the surrounding terms
+7: [normal] String concatenation should be formatted with a space separating the operators (dot .) and the surrounding terms
+17: [normal] use quotes around a string literal array index, this is not only a style issue, but a known performance problem
+18: [normal] use quotes around a string literal array index, this is not only a style issue, but a known performance problem
+19: [normal] use quotes around a string literal array index, this is not only a style issue, but a known performance problem
+20: [normal] use quotes around a string literal array index, this is not only a style issue, but a known performance problem
+21: [normal] use quotes around a string literal array index, this is not only a style issue, but a known performance problem
+22: [normal] use quotes around a string literal array index, this is not only a style issue, but a known performance problem
+23: [normal] use quotes around a string literal array index, this is not only a style issue, but a known performance problem
+24: [normal] use quotes around a string literal array index, this is not only a style issue, but a known performance problem
+25: [normal] use quotes around a string literal array index, this is not only a style issue, but a known performance problem
+26: [normal] use quotes around a string literal array index, this is not only a style issue, but a known performance problem
+35: [normal] use quotes around a string literal array index, this is not only a style issue, but a known performance problem
+39: [normal] use quotes around a string literal array index, this is not only a style issue, but a known performance problem
+40: [normal] use quotes around a string literal array index, this is not only a style issue, but a known performance problem
+41: [normal] use quotes around a string literal array index, this is not only a style issue, but a known performance problem
+45: [normal] use quotes around a string literal array index, this is not only a style issue, but a known performance problem
+46: [normal] use quotes around a string literal array index, this is not only a style issue, but a known performance problem
+50: [normal] use quotes around a string literal array index, this is not only a style issue, but a known performance problem
+51: [normal] use quotes around a string literal array index, this is not only a style issue, but a known performance problem
+52: [normal] use quotes around a string literal array index, this is not only a style issue, but a known performance problem
+53: [normal] use quotes around a string literal array index, this is not only a style issue, but a known performance problem
+54: [normal] use quotes around a string literal array index, this is not only a style issue, but a known performance problem
+58: [normal] use quotes around a string literal array index, this is not only a style issue, but a known performance problem
+59: [normal] use quotes around a string literal array index, this is not only a style issue, but a known performance problem
+60: [normal] use quotes around a string literal array index, this is not only a style issue, but a known performance problem
+64: [normal] use quotes around a string literal array index, this is not only a style issue, but a known performance problem
+65: [normal] use quotes around a string literal array index, this is not only a style issue, but a known performance problem
+69: [normal] use quotes around a string literal array index, this is not only a style issue, but a known performance problem
+84: [normal] use quotes around a string literal array index, this is not only a style issue, but a known performance problem
+85: [normal] use quotes around a string literal array index, this is not only a style issue, but a known performance problem
+89: [normal] use quotes around a string literal array index, this is not only a style issue, but a known performance problem
+90: [normal] use quotes around a string literal array index, this is not only a style issue, but a known performance problem
+91: [normal] use quotes around a string literal array index, this is not only a style issue, but a known performance problem
+92: [normal] use quotes around a string literal array index, this is not only a style issue, but a known performance problem
+93: [normal] use quotes around a string literal array index, this is not only a style issue, but a known performance problem
+97: [normal] use quotes around a string literal array index, this is not only a style issue, but a known performance problem
+98: [normal] use quotes around a string literal array index, this is not only a style issue, but a known performance problem
+99: [normal] use quotes around a string literal array index, this is not only a style issue, but a known performance problem
+100: [normal] use quotes around a string literal array index, this is not only a style issue, but a known performance problem
+101: [normal] use quotes around a string literal array index, this is not only a style issue, but a known performance problem
+102: [normal] use quotes around a string literal array index, this is not only a style issue, but a known performance problem
+103: [normal] use quotes around a string literal array index, this is not only a style issue, but a known performance problem
+104: [normal] use quotes around a string literal array index, this is not only a style issue, but a known performance problem
+105: [normal] use quotes around a string literal array index, this is not only a style issue, but a known performance problem
+106: [normal] use quotes around a string literal array index, this is not only a style issue, but a known performance problem
+107: [normal] use quotes around a string literal array index, this is not only a style issue, but a known performance problem
+108: [normal] use quotes around a string literal array index, this is not only a style issue, but a known performance problem
+109: [normal] use quotes around a string literal array index, this is not only a style issue, but a known performance problem
+113: [normal] use quotes around a string literal array index, this is not only a style issue, but a known performance problem
+114: [normal] use quotes around a string literal array index, this is not only a style issue, but a known performance problem
+115: [normal] use quotes around a string literal array index, this is not only a style issue, but a known performance problem
+116: [normal] use quotes around a string literal array index, this is not only a style issue, but a known performance problem
+117: [normal] use quotes around a string literal array index, this is not only a style issue, but a known performance problem
+118: [normal] use quotes around a string literal array index, this is not only a style issue, but a known performance problem
+119: [normal] use quotes around a string literal array index, this is not only a style issue, but a known performance problem
+120: [normal] use quotes around a string literal array index, this is not only a style issue, but a known performance problem
+121: [normal] use quotes around a string literal array index, this is not only a style issue, but a known performance problem
+122: [normal] use quotes around a string literal array index, this is not only a style issue, but a known performance problem
+126: [normal] use quotes around a string literal array index, this is not only a style issue, but a known performance problem
+127: [normal] use quotes around a string literal array index, this is not only a style issue, but a known performance problem
+128: [normal] use quotes around a string literal array index, this is not only a style issue, but a known performance problem
+129: [normal] use quotes around a string literal array index, this is not only a style issue, but a known performance problem
+130: [normal] use quotes around a string literal array index, this is not only a style issue, but a known performance problem
+131: [normal] use quotes around a string literal array index, this is not only a style issue, but a known performance problem
+132: [normal] use quotes around a string literal array index, this is not only a style issue, but a known performance problem
+136: [normal] use quotes around a string literal array index, this is not only a style issue, but a known performance problem
+137: [normal] use quotes around a string literal array index, this is not only a style issue, but a known performance problem
+141: [normal] use quotes around a string literal array index, this is not only a style issue, but a known performance problem
+149: [normal] use quotes around a string literal array index, this is not only a style issue, but a known performance problem
+153: [normal] String concatenation should be formatted with a space separating the operators (dot .) and the surrounding terms
+155: [normal] use quotes around a string literal array index, this is not only a style issue, but a known performance problem
+156: [normal] use quotes around a string literal array index, this is not only a style issue, but a known performance problem
+157: [normal] use quotes around a string literal array index, this is not only a style issue, but a known performance problem
+158: [normal] use quotes around a string literal array index, this is not only a style issue, but a known performance problem
+159: [normal] use quotes around a string literal array index, this is not only a style issue, but a known performance problem
+160: [normal] use quotes around a string literal array index, this is not only a style issue, but a known performance problem
+162: [normal] use quotes around a string literal array index, this is not only a style issue, but a known performance problem
+163: [normal] use quotes around a string literal array index, this is not only a style issue, but a known performance problem
+164: [normal] use quotes around a string literal array index, this is not only a style issue, but a known performance problem
+165: [normal] use quotes around a string literal array index, this is not only a style issue, but a known performance problem
+166: [normal] use quotes around a string literal array index, this is not only a style issue, but a known performance problem
+167: [normal] use quotes around a string literal array index, this is not only a style issue, but a known performance problem
+168: [normal] use quotes around a string literal array index, this is not only a style issue, but a known performance problem
+169: [normal] use quotes around a string literal array index, this is not only a style issue, but a known performance problem
+170: [normal] use quotes around a string literal array index, this is not only a style issue, but a known performance problem
+171: [normal] use quotes around a string literal array index, this is not only a style issue, but a known performance problem
+172: [normal] use quotes around a string literal array index, this is not only a style issue, but a known performance problem
+173: [normal] use quotes around a string literal array index, this is not only a style issue, but a known performance problem
+174: [normal] use quotes around a string literal array index, this is not only a style issue, but a known performance problem
+175: [normal] use quotes around a string literal array index, this is not only a style issue, but a known performance problem
+176: [normal] use quotes around a string literal array index, this is not only a style issue, but a known performance problem
+177: [normal] use quotes around a string literal array index, this is not only a style issue, but a known performance problem
+178: [normal] use quotes around a string literal array index, this is not only a style issue, but a known performance problem
+179: [normal] use quotes around a string literal array index, this is not only a style issue, but a known performance problem
+180: [normal] use quotes around a string literal array index, this is not only a style issue, but a known performance problem
+181: [normal] use quotes around a string literal array index, this is not only a style issue, but a known performance problem
+182: [normal] use quotes around a string literal array index, this is not only a style issue, but a known performance problem
+183: [normal] use quotes around a string literal array index, this is not only a style issue, but a known performance problem
+184: [normal] use quotes around a string literal array index, this is not only a style issue, but a known performance problem
+185: [normal] use quotes around a string literal array index, this is not only a style issue, but a known performance problem
+211: [normal] String concatenation should be formatted with a space separating the operators (dot .) and the surrounding terms
sites/all/themes/bootstrap/templates/webform/webform-element.vars.php:
No Problems Found
sites/all/themes/bootstrap/templates/views/views-view-table.tpl.php:
+26: [normal] The control statement should use ":" syntax instead of curly braces.
+34: [normal] The control statement should use ":" syntax instead of curly braces.
+43: [normal] The control statement should use ":" syntax instead of curly braces.
+45: [normal] The control statement should use ":" syntax instead of curly braces.
sites/all/themes/bootstrap/templates/views/views-view-table.vars.php:
No Problems Found
sites/all/themes/bootstrap/templates/system/breadcrumb.func.php:
No Problems Found
sites/all/themes/bootstrap/templates/system/breadcrumb.vars.php:
No Problems Found
sites/all/themes/bootstrap/templates/system/button.func.php:
No Problems Found
sites/all/themes/bootstrap/templates/system/button.vars.php:
No Problems Found
sites/all/themes/bootstrap/templates/system/container.func.php:
No Problems Found
sites/all/themes/bootstrap/templates/system/date.func.php:
No Problems Found
sites/all/themes/bootstrap/templates/system/exposed-filters.func.php:
No Problems Found
sites/all/themes/bootstrap/templates/system/fieldset.func.php:
No Problems Found
sites/all/themes/bootstrap/templates/system/form-element-label.func.php:
No Problems Found
sites/all/themes/bootstrap/templates/system/form-element.func.php:
No Problems Found
sites/all/themes/bootstrap/templates/system/html-tag.vars.php:
No Problems Found
sites/all/themes/bootstrap/templates/system/html.tpl.php:
No Problems Found
sites/all/themes/bootstrap/templates/system/html.vars.php:
No Problems Found
sites/all/themes/bootstrap/templates/system/image.vars.php:
No Problems Found
sites/all/themes/bootstrap/templates/system/item-list.func.php:
No Problems Found
sites/all/themes/bootstrap/templates/system/links.vars.php:
No Problems Found
sites/all/themes/bootstrap/templates/system/mark.func.php:
No Problems Found
sites/all/themes/bootstrap/templates/system/page.tpl.php:
No Problems Found
sites/all/themes/bootstrap/templates/system/page.vars.php:
+28: [normal] Control statements should have one space between the control keyword and opening parenthesis
+58: [normal] Control statements should have one space between the control keyword and opening parenthesis
sites/all/themes/bootstrap/templates/system/pager.func.php:
No Problems Found
sites/all/themes/bootstrap/templates/system/progress-bar.tpl.php:
No Problems Found
sites/all/themes/bootstrap/templates/system/region.vars.php:
No Problems Found
sites/all/themes/bootstrap/templates/system/status-messages.func.php:
No Problems Found
sites/all/themes/bootstrap/templates/system/table.func.php:
No Problems Found
sites/all/themes/bootstrap/templates/system/table.vars.php:
No Problems Found
sites/all/themes/bootstrap/templates/system/textfield.func.php:
No Problems Found
sites/all/themes/bootstrap/templates/search/search-block-form.tpl.php:
No Problems Found
sites/all/themes/bootstrap/templates/poll/poll-bar--block.tpl.php:
No Problems Found
sites/all/themes/bootstrap/templates/poll/poll-bar.tpl.php:
No Problems Found
sites/all/themes/bootstrap/templates/picture/image-srcset.vars.php:
No Problems Found
sites/all/themes/bootstrap/templates/picture/picture.vars.php:
No Problems Found
sites/all/themes/bootstrap/templates/node/node.tpl.php:
No Problems Found
sites/all/themes/bootstrap/templates/menu/menu-link.func.php:
No Problems Found
sites/all/themes/bootstrap/templates/menu/menu-local-action.func.php:
No Problems Found
sites/all/themes/bootstrap/templates/menu/menu-local-task.func.php:
No Problems Found
sites/all/themes/bootstrap/templates/menu/menu-local-tasks.func.php:
No Problems Found
sites/all/themes/bootstrap/templates/menu/menu-tree.func.php:
No Problems Found
sites/all/themes/bootstrap/templates/image/image-widget.func.php:
No Problems Found
sites/all/themes/bootstrap/templates/icon/icon.vars.php:
No Problems Found
sites/all/themes/bootstrap/templates/filter/filter-tips-more-info.func.php:
No Problems Found
sites/all/themes/bootstrap/templates/filter/filter-tips.func.php:
No Problems Found
sites/all/themes/bootstrap/templates/filter/text-format-wrapper.func.php:
No Problems Found
sites/all/themes/bootstrap/templates/file/file-managed-file.func.php:
No Problems Found
sites/all/themes/bootstrap/templates/file/file-upload-help.func.php:
No Problems Found
sites/all/themes/bootstrap/templates/file/file-widget-multiple.func.php:
No Problems Found
sites/all/themes/bootstrap/templates/file/file-widget.func.php:
No Problems Found
sites/all/themes/bootstrap/templates/bootstrap/bootstrap-carousel.tpl.php:
No Problems Found
sites/all/themes/bootstrap/templates/bootstrap/bootstrap-carousel.vars.php:
No Problems Found
sites/all/themes/bootstrap/templates/bootstrap/bootstrap-dropdown.func.php:
No Problems Found
sites/all/themes/bootstrap/templates/bootstrap/bootstrap-dropdown.vars.php:
No Problems Found
sites/all/themes/bootstrap/templates/bootstrap/bootstrap-modal.tpl.php:
No Problems Found
sites/all/themes/bootstrap/templates/bootstrap/bootstrap-modal.vars.php:
No Problems Found
sites/all/themes/bootstrap/templates/bootstrap/bootstrap-panel.tpl.php:
No Problems Found
sites/all/themes/bootstrap/templates/bootstrap/bootstrap-panel.vars.php:
No Problems Found
sites/all/themes/bootstrap/templates/bootstrap/bootstrap-search-form-wrapper.func.php:
No Problems Found
sites/all/themes/bootstrap/templates/book/book-navigation.tpl.php:
No Problems Found
sites/all/themes/bootstrap/templates/book/book-navigation.vars.php:
No Problems Found
sites/all/themes/bootstrap/templates/block/block-admin-display-form.tpl.php:
No Problems Found
sites/all/themes/bootstrap/templates/block/block.tpl.php:
No Problems Found
sites/all/themes/bootstrap/templates/block/block.vars.php:
No Problems Found
sites/all/themes/bootstrap/templates/admin_menu/admin-menu-links.vars.php:
No Problems Found
sites/all/themes/bootstrap/starterkits/less/template.php:
No Problems Found
sites/all/themes/bootstrap/starterkits/cdn/template.php:
No Problems Found
sites/all/themes/bootstrap/js/modules/views/js/ajax_view.js:
No Problems Found
sites/all/themes/bootstrap/js/modules/user/user.js:
No Problems Found
sites/all/themes/bootstrap/js/modules/filter/filter.js:
No Problems Found
sites/all/themes/bootstrap/js/modules/file/file.js:
No Problems Found
sites/all/themes/bootstrap/js/modules/field_ui/field_ui.js:
No Problems Found
sites/all/themes/bootstrap/js/modules/dashboard/dashboard.js:
No Problems Found
sites/all/themes/bootstrap/js/modules/ctools/js/modal.js:
No Problems Found
sites/all/themes/bootstrap/js/modules/comment/_comment-node-form.js:
No Problems Found
sites/all/themes/bootstrap/js/misc/_collapse.js:
No Problems Found
sites/all/themes/bootstrap/js/misc/_progress.js:
No Problems Found
sites/all/themes/bootstrap/js/misc/_vertical-tabs.js:
No Problems Found
sites/all/themes/bootstrap/js/misc/ajax.js:
No Problems Found
sites/all/themes/bootstrap/js/misc/autocomplete.js:
No Problems Found
sites/all/themes/bootstrap/js/misc/states.js:
No Problems Found
sites/all/themes/bootstrap/js/misc/tabledrag.js:
No Problems Found
sites/all/themes/bootstrap/js/bootstrap.admin.js:
No Problems Found
sites/all/themes/bootstrap/js/bootstrap.js:
No Problems Found
sites/all/themes/bootstrap/includes/alter.inc:
+132: [normal] Use "elseif" in place of "else if"
+182: [normal] Use "elseif" in place of "else if"
sites/all/themes/bootstrap/includes/cdn.inc:
No Problems Found
sites/all/themes/bootstrap/includes/common.inc:
No Problems Found
sites/all/themes/bootstrap/includes/deprecated.inc:
No Problems Found
sites/all/themes/bootstrap/includes/icons.inc:
No Problems Found
sites/all/themes/bootstrap/includes/pre-render.inc:
No Problems Found
sites/all/themes/bootstrap/includes/process.inc:
No Problems Found
sites/all/themes/bootstrap/includes/registry.inc:
+372: [normal] missing space after comma
+471: [normal] missing space after comma
sites/all/themes/bootstrap/grunt/config/autoprefixer.js:
No Problems Found
sites/all/themes/bootstrap/grunt/config/clean.js:
No Problems Found
sites/all/themes/bootstrap/grunt/config/cssmin.js:
No Problems Found
sites/all/themes/bootstrap/grunt/config/githooks.js:
No Problems Found
sites/all/themes/bootstrap/grunt/config/watch.js:
No Problems Found
sites/all/themes/bootstrap/grunt/clean-vendor-dirs.js:
No Problems Found
sites/all/themes/bootstrap/grunt/compile.js:
No Problems Found
sites/all/themes/bootstrap/grunt/sync.js:
No Problems Found
sites/all/themes/bootstrap/bootstrap.api.php:
No Problems Found
sites/all/themes/bootstrap/Gruntfile.js:
No Problems Found
sites/all/themes/bootstrap/template.php:
No Problems Found
sites/all/themes/bootstrap/theme-settings.php:
+41: [critical] Potential problem: drupal_set_message() only accepts filtered text, be sure all !placeholders for $variables in t() are fully sanitized using check_plain(), filter_xss() or similar.
Status Messages:
Coder found 1 projects, 104 files, 1 critical warnings, 113 normal warnings, 0 warnings were flagged to be ignored
| Comment | File | Size | Author |
|---|
Comments
Comment #2
markhalliwell'works just as well has".The above message makes it seem as if there is a bigger issue than there really is. I have to say... this is quite insulting, especially without any patch to fix these very minor issues...
Comment #3
larsdesigns CreditAttribution: larsdesigns as a volunteer and at LarsDesigns Information Systems Inc. commented@markcarver, There is no insult intended I assure you. Just trying to improve the code according to the standards put in place by the community.
I recommend configuring the phpcs plugin in the IDE you mentioned to use the Drupal option "--standard=Drupal". Here is an example of the command:
This should help bring out the details specific to a Drupal project.
Comment #5
markhalliwellAs I already stated above, my IDE is already integrated with CodeSniffer and configured to use the "Drupal" (coder module) profile. I have long been aware of the coder module and coding standards the community have created:
The word "improve" is really up to interpretation here. The "standards" you kindly mention are merely guidelines. Again, the fact that this project does follow these recommendations (nearly 100% btw) is rare in the contrib space. The above "errors" are purely cosmetic in nature and do not actually affect anyone or anything other than some sense of conformity and shunning those who don't (hence the insult).
I strongly recommend that if you plan on opening issues like this, you also file a patch to fix them. Those who actually maintain code have better things to do than deal with minor annoyances and semantics like this (hence the insult).
Regardless, I've committed the following fixes. I did not (and will not) touch the .info file. As I stated above, the coder inspection is wrong. Drupal uses it's own parser for .info files (drupal_parse_info_file() and drupal_parse_info_format()) and does not recognize any quotes around array keys.
Comment #6
larsdesigns CreditAttribution: larsdesigns as a volunteer and at LarsDesigns Information Systems Inc. commentedThank you for improving the code. However, I do not agree with your strong recommendation that I should provide patches for every issue that I open. Everyone is welcome to open issues. That is part of open source fundamentals and an important aspect to the Drupal community. You should be appreciative that I took the time to contribute to this project. Even if it was just reporting a valid issue.
Publishing clean code is important on so many different levels.
I am sorry you feel so insulted. Maybe you should ask yourself if being a code maintainer in an open source community fits your personality.
We are all just trying to help and share with each other at the end of the day. I appreciate your contributions.
Comment #7
markhalliwellThat's not what I said. I said issues like this one.
I get people reporting things all the time. It doesn't make them "valid". This report was nothing more than a copy and paste from coder's review of this project's source code. I stopped using coder's report years ago because it's too particular (and sometimes outdated) on interpretations of our community's coding "standards".
No, what you did is report cosmetic indifferences. What I actually committed didn't affect the functionality or readability of the project whatsoever. I committed it because, from my experience in the past with issues like this, when I close them as "won't fix", I end up doing it anyway after relentless comments back and forth. That's not "improvement", that's quickly dealing with annoyance.
Also, FYI, the coder module was primarily created for reviewing full project applications. It was intended purely as a quick analysis to improve the code of new users who were unfamiliar with our community coding standards. I assure you, I am not a new user trying to get my project reviewed. Can you see how an issue, like this one, can be perceived as somewhat "insulting" by someone like me who actually knows what that module's intended purpose is primarily for?
I agree. However, the fact that you didn't provide a patch for something so trivial is what made this statement (that you just said) obvious from the beginning. That is what was perceived as "insulting" to me. You are inferring that the entire project's code base wasn't "clean". In fact, it was and still is.
Did it have a few, very minor, mistakes... sure. I won't deny that. I take great amount of pride in coding clean, easy to read and well documented code. If you actually read through it all, you'd know that.
Sometimes mistakes happen. I'll give you an example that's actually valid: #2628012: Wrong comment in status-messages.func.php theme template. That entire file technically "passes" the coder's review process, but it doesn't actually mean there's no errors in it. That is why I put very little stock into using it for an actual base-line of how "good" a code base is. It helps with conformity, but you misunderstand that's it's not actually authoritative.
It does fit my personality. I have no problem with people reporting real issues (as with the issue I linked above). What I have a problem with is when people "report" something so trivial and indifferent to opinion that makes issues like this bigger than they really are. Maybe you should contribute and maintain code that's used on thousands of sites and get issues every day about one thing or another before asking whether or not someone is the right person for the job? Seriously...
There are many different types of contributors, I know. Anyone can report issues, true. How and what you report is what makes a valuable contributor. Sigh, you're sadly missing the entire point of what this "issue" really is about.
Am I really insulted, no. I mistyped "quite" for "kind of" in my original comment. I was just trying to explain that its also considered "good form" in our community to follow-up very small/trivial issues like this with a patch is all. Issues like this aren't something most maintainers will typically make the time to fix (I am an exception to this though).
Regardless, it's committed. Let it be.
Comment #8
markhalliwellAnd this is why I hate the coder module...