Add Telangana - India's 29th state in INDIA_356_2.cif

Comments

visabhishek created an issue. See original summary.

visabhishek’s picture

Component: Products » Other
Status: Active » Needs review
StatusFileSize
new496 bytes

Please find the patch

tr’s picture

Title: Add Telangana - India's 29th state in INDIA_356_2.cif » Update india_356_2.cif
StatusFileSize
new8 KB

There are additional changes needed, as well as additions to india_update() to make sure existing sites get these changes.

Here are the the ISO 3166-2 updates to IN since india_356_2.cif was last modified:

2014-10-30 	Add 1 state IN-TG; change spelling of IN-OR; update List Source and Code Source
2011-12-13 	Addition of local generic administrative terms, update of the official languages according to ISO 3166-2, addition of a comment and source list update.

The attached patch makes these modifications and adds the update functionality.

Please review the entire CIF for accuracy, especially:
1) Subdivision names
2) Subdivision codes
3) Address format (very important!)

Also, please test the patch by applying it then using the update link at admin/store/settings/countries to update your site's country information. Note, you will have to revert any changes you've made to your copy of india_356_2.cif before you apply the patch.

Status: Needs review » Needs work

The last submitted patch, 3: 2629392-india-cif.patch, failed testing.

The last submitted patch, 3: 2629392-india-cif.patch, failed testing.

tr’s picture

Status: Needs work » Needs review
StatusFileSize
new9.14 KB

Sorry, the patch in #3 was for 6.x-2.x. Here's the correct patch for 7.x-3.x

tr’s picture

@visabhishek, can you test this?

visabhishek’s picture

Status: Needs review » Reviewed & tested by the community

Hi TR,

Patch looks good and, working fine for me.

longwave’s picture

Status: Reviewed & tested by the community » Needs work

I think there is something wrong with the country update code.

I installed india_356_2.cif from the 7.x-3.x repo. Then I patched with #6 and clicked "update" in the UI. I now have Telangana added, but I also have two duplicates: Lakshadweep and Puducherry are listed twice in the database. It seems like update 2 ran again, even though it didn't need to? The version numbers were correct before and after the update, however.

longwave’s picture

Status: Needs work » Needs review
StatusFileSize
new2.55 KB

This patch fixes the update logic. This would only affect countries with two updates and that add new zones in update 2, which is probably why it wasn't spotted before - this only seems to apply to Italy and New Zealand.

  • TR committed c9201bf on 7.x-3.x
    Issue #2629392 by TR, longwave: Update india_356_2.cif
    
tr’s picture

Version: 7.x-3.x-dev » 6.x-2.x-dev
StatusFileSize
new8.49 KB

Committed fix for 7.x-3.x, here's a re-roll of #3 for 6.x-2.x including the update logic fix from #10.

Status: Needs review » Needs work

The last submitted patch, 12: 2629392-india-cif.patch, failed testing.

  • TR committed 0605cd7 on 8.x-4.x
    Issue #2629392: Update uc_country.country.IN.yml
    
tr’s picture

Fix committed to 8.x-4.x

tr’s picture

DrupalCI is testing the D6 patch against D7.

  • TR committed 690fe4a on 6.x-2.x
    Issue #2629392 by TR, longwave: Update india_356_2.cif
    
tr’s picture

Status: Needs work » Fixed

Committed #12 to 6.x-2.x

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.