Closed (fixed)
Project:
Ubercart
Version:
6.x-2.x-dev
Component:
Other
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
5 Dec 2015 at 07:27 UTC
Updated:
1 Jan 2016 at 19:14 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
visabhishek commentedPlease find the patch
Comment #3
tr commentedThere are additional changes needed, as well as additions to india_update() to make sure existing sites get these changes.
Here are the the ISO 3166-2 updates to IN since india_356_2.cif was last modified:
The attached patch makes these modifications and adds the update functionality.
Please review the entire CIF for accuracy, especially:
1) Subdivision names
2) Subdivision codes
3) Address format (very important!)
Also, please test the patch by applying it then using the update link at admin/store/settings/countries to update your site's country information. Note, you will have to revert any changes you've made to your copy of india_356_2.cif before you apply the patch.
Comment #6
tr commentedSorry, the patch in #3 was for 6.x-2.x. Here's the correct patch for 7.x-3.x
Comment #7
tr commented@visabhishek, can you test this?
Comment #8
visabhishek commentedHi TR,
Patch looks good and, working fine for me.
Comment #9
longwaveI think there is something wrong with the country update code.
I installed india_356_2.cif from the 7.x-3.x repo. Then I patched with #6 and clicked "update" in the UI. I now have Telangana added, but I also have two duplicates: Lakshadweep and Puducherry are listed twice in the database. It seems like update 2 ran again, even though it didn't need to? The version numbers were correct before and after the update, however.
Comment #10
longwaveThis patch fixes the update logic. This would only affect countries with two updates and that add new zones in update 2, which is probably why it wasn't spotted before - this only seems to apply to Italy and New Zealand.
Comment #12
tr commentedCommitted fix for 7.x-3.x, here's a re-roll of #3 for 6.x-2.x including the update logic fix from #10.
Comment #15
tr commentedFix committed to 8.x-4.x
Comment #16
tr commentedDrupalCI is testing the D6 patch against D7.
Comment #18
tr commentedCommitted #12 to 6.x-2.x