Acquia Lift overrides CTools modal.js but doesn't specify or pass a class to Drupal.CTools.Modal.modalContent as the original function does. This results in the modal receiving the class modal-undefined.

CommentFileSizeAuthor
#4 2626792.acquia_lift.ctools_modal_class.4.patch306.63 KBeshta
#3 modal_undefined.jpg116.74 KBdevin carlson
#2 add-default-modal-class-2626792-2.patch1.73 KBdevin carlson

Comments

Devin Carlson created an issue. See original summary.

devin carlson’s picture

devin carlson commented
Status: Active » Needs review
StatusFileSize
new add-default-modal-class-2626792-2.patch1.73 KB

A patch to add a default modal class and pass it to modalContent.

devin carlson’s picture

devin carlson commented
StatusFileSize
new modal_undefined.jpg116.74 KB

An image which shows the missing modal class.

eshta’s picture

eshta commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new 2626792.acquia_lift.ctools_modal_class.4.patch306.63 KB

Updating patch to add sourcemap generation via grunt concat.

  • eshta committed 9f1a92b on 7.x-2.x 
    Issue #2626792 by Devin Carlson: CH-4392 CTools modals are missing...
eshta’s picture

eshta commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.