Order::create() is better and more flexible.

CommentFileSizeAuthor
#3 2626128-order-new.patch2.2 KBtr

Comments

longwave created an issue. See original summary.

tr’s picture

tr commented

Yes, I removed all usage of that function back in commit be2c722, I just never removed the function itself.

tr’s picture

tr commented
Status: Active » Needs review
StatusFileSize
new 2626128-order-new.patch2.2 KB

This patch also removes uc_order_create_for_user() (which called uc_order_new()). As far as I can tell, this is an old convenience function which wasn't used in D7 and isn't needed in D8.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented

uc_order_create_for_user() was the callback for a local action on /admin/store/customers/orders/%, created via uc_order_menu_local_tasks_alter() - not sure whether it is worth keeping this?

  • longwave committed e3a72b0 on authored by TR 
    Issue #2626128 by TR, longwave: Remove uc_order_new()
longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs review » Fixed

uc_order_create_for_user() was converted in #2627704: Fix 'Create order for this customer' local action, I also added a CHANGELOG.txt entry to cover uc_order_new() when committing this.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.