The image button does not work unless width+height attributes are allowed, even though those are optional

Please export your text format and text editor's configuration, so I can try to reproduce this.

#3 is correct: if the <img> tag is whitelisted along with those attributes, it should show up.

Thanks! Will try to reproduce.

@wimleers I was able to reproduce on a clean 8.0.x by importing the configuration provided at #5.

I tried debugging and found out that on admin/config/content/formats/manage/test_format Line 245 of core/modules/filter/filter.filter_html.admin.js gives an error caught TypeError: Cannot read property 'tagName' of null.

I will try investigating further.

Looks like the error was not relevant but still must be investigated. The configuration was missing the data-entity-type data-entity-uuid attributes.

Changing <img src alt height width data-align data-caption> to <img src alt height width data-entity-type data-entity-uuid data-align data-caption> I am able to see the the drupalimage icon on the editor.

@gceja did you remove the data-entity-type data-entity-uuid attributes while creating the text format?

@gceja Great to see that you got it resolved!

@wimleers should this considered as a non-issue and be closed? Tagging accordingly.

Confirming #3:

After further testing, we discovered that the "Limit allowed HTML tags and correct faulty HTML" Enabled filter is the one that is preventing the Image button from showing up in the CKEditor Toolbox for the custom Text Format;

@jepSter Could it be the same case as #9? If not, could you please you provide more information on how to replicate and export your text format and text editor's configuration?

Same issue for me. The icon is present in the toolbar, but when I click on it, nothing happens. No JS errors either.

Have <img src alt data-entity-type data-entity-uuid>in the Allowed HTML tags.

The only way to enable the image modal is to uncheck Limit allowed HTML tags and correct faulty HTML

I believe I was encountering a very similar issue, or likely the same with some variation.

1. Create a custom text format with the image plugin enabled.
2. Go to add a node with the text format enabled.
3. Switch to the custom text format (I had set it to be the default, but the node still reverts to Basic HTML. A different issue I guess?)
4. Image icon is showing, but clicking on it does nothing.

No js errors in the console. Clicking the plugin does appear to make some requests to some cryptic url (data:image/gif;base64,R0lGODlhAQABAPABAP///wAAACH5BAEKAAAALAAAAAABAAEAAAICRAEAOw==), I have no idea what this is.

Updating from 8.0.2 to 8.0.3 seems to have fixed this.

Edit: This is still broken in 8.0.3. I had disabled the "Limit allowed HTML tags and correct faulty HTML" filter while trying out a few things.

I'm having similar issue;

• New installation, 8.0.3
• Create new format with CKEditor, enable image, enable "Allowed HTML tags" filter (and make sure IMG is allowed)
• Clicking on insert image button during editing does nothing, no error.
• If I insert image manually to the source, it's displayed.
• (WYSIWYG mode) If I right-click on manually inserted image and select image properties, nothing happens. No error.

Same issue here (8.0.0 and 8.0.3). but it worked when I added width and height to the img in allowed tags, see if that works for you.

@Jon@s #16 That fixed my issue, thank you very much!

Added related issue Image dialog on custom text format with limit html doesn't work [2677142] under editor.module which I believe is the root of the problem.

This was a small oversight in #2519862: Remove the width/height inputs from EditorImageDialog. Which never really was a problem, until #2549077: Allow the "Limit allowed HTML tags" filter to also restrict HTML attributes, and only allow a small whitelist of attributes by default landed a few months later. It's the combination of those two that caused this problem.

Fix attached: it's simply the drupalimage CKEditor plugin whose requiredContent setting requiring too much.

RTBC for me :)
I let @thpoul change the status if he agrees.

Let's be more clear.

@DuaelFr, did you do manual testing?

Yes, I did :)
I reproduced the issue then patched Core to see it fixed.
Reviewed code too (not so long ^^).

Perfect :)

Was waiting for the test to turn green to comment. I can confirm the patch works by manual testing it and by #21 changing the status to RTBC

Thank you guys.

Committed/pushed to all three 8.x branches, thanks!