Currently we don't display any list of media entities. Would probably make sense to make one. Some initial code was already created as part of #2622190: Menu link for adding new Media entity doesn't exist.

CommentFileSizeAuthor
#7 consider_adding_default-2626064-7-interdiff.txt2.34 KBmbovan
#7 consider_adding_default-2626064-7.patch27.74 KBmbovan
#7 media_overview_page_operations.png62.24 KBmbovan
#5 media_overview_page_tab.png13.77 KBmbovan
#5 media_overview_page_no_items.png38.42 KBmbovan
#5 media_overview_page.png62.41 KBmbovan
#4 consider_adding_default-2626064-4-interdiff.txt11.28 KBmbovan
#4 consider_adding_default-2626064-4.patch25.77 KBmbovan
#2 consider_adding_default-2626064-2.patch21.34 KBluksak

Comments

slashrsm created an issue. See original summary.

luksak’s picture

luksak
he/him
commented
Status: Active » Needs review
StatusFileSize
new consider_adding_default-2626064-2.patch21.34 KB

Re-rolling patch from #2622190: Menu link for adding new Media entity doesn't exist. It will not apply since the patch from that issue has not been pushed yet. As soon this is the case it will work.

Status: Needs review » Needs work

The last submitted patch, 2: consider_adding_default-2626064-2.patch, failed testing.

mbovan’s picture

mbovan commented
Status: Needs work » Needs review
StatusFileSize
new consider_adding_default-2626064-4.patch25.77 KB
new consider_adding_default-2626064-4-interdiff.txt11.28 KB

The view configuration above produced some test fails regarding schema.

Fixed it, added new tests for media overview page. Also, I uncommented some tests methods and updated them according to latest changes.

Btw, the button we added in #2622190: Menu link for adding new Media entity doesn't exist is now moved to media overview page. (admin/content/media)

mbovan’s picture

mbovan commented
StatusFileSize
new media_overview_page.png62.41 KB
new media_overview_page_no_items.png38.42 KB
new media_overview_page_tab.png13.77 KB

Here are the UI changes made by the patches above:

A tab to access media overview page
Media tab

Media overview page with no content available.
Media overview page - no items

Media overview page with entities in the list.
Media overview page - items

euphoric_mv’s picture

euphoric_mv commented

Maybe it is good to have Edit and Delete links on this listing view.

mbovan’s picture

mbovan commented
StatusFileSize
new media_overview_page_operations.png62.24 KB
new consider_adding_default-2626064-7.patch27.74 KB
new consider_adding_default-2626064-7-interdiff.txt2.34 KB

Probably yes. Adding this.

Media overview page operations

slashrsm’s picture

slashrsm commented
Status: Needs review » Fixed

Committed. Thanks!

  • slashrsm committed 3b855e2 on 8.x-1.x authored by mbovan 
    Issue #2626064 by mbovan, Lukas von Blarer: Consider adding default...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.