Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
In Editor module add missing @param
and @return
.
Comment | File | Size | Author |
---|---|---|---|
#13 | interdiff-2625512-9-13.txt | 431 bytes | heykarthikwithu |
#13 | removal_of_redundant-2625512-13.patch | 1.98 KB | heykarthikwithu |
#9 | interdiff-2625512-7-9.txt | 769 bytes | heykarthikwithu |
#9 | removal_of_redundant-2625512-9.patch | 1.48 KB | heykarthikwithu |
#7 | interdiff.txt | 2.35 KB | Mac_Weber |
Comments
Comment #2
heykarthikwithuRemoved the redundant variable, and added @return, @param.
Comment #3
schoash CreditAttribution: schoash as a volunteer commentedtested on 8.0.x and 8.1.x-dev.
It works on both and looks ok.
Comment #4
droplet CreditAttribution: droplet commentedSorry, I forgot to mention it also on quickedit modules. We may have to change them all to keep consistent code in those files.
Comment #5
Wim LeersNo. Please don't change this. This variable is intentionally there, for legibility.
We don't do this for
#pre_render
callbacks.s/format/text format/
LOL.
Omit the second line, please. The single-line explanation at the top of this docblock already covers this.
LOL. Needs to be fixed. This is useless.
Inaccurate.
Comment #6
heykarthikwithuComment #7
Mac_Weber CreditAttribution: Mac_Weber as a volunteer commentedDid the changes pointed by @Wim Leers at #5, in addition to s/id/ID/ and:
Comment #8
Wim LeersJust two more nits, then this is RTBC:
Returns the in-place editor that quickedit selects.
Returns the selected in-place editor.
Comment #9
heykarthikwithuAs per #8, changes are done.
Comment #10
Wim LeersComment #11
alexpottAfaics there is one missing...
function editor_load($format_id) {
every other function is either a hook or callback which don't need documentation.Comment #12
heykarthikwithuComment #13
heykarthikwithuAs per #11, changes are appended.
Comment #14
Wim LeersComment #15
alexpottCommitted 102928a and pushed to 8.0.x. Thanks!