Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
editor.module
Priority:
Minor
Category:
Bug report
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
30 Nov 2015 at 05:42 UTC
Updated:
19 Jan 2016 at 10:44 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
heykarthikwithuRemoved the redundant variable, and added @return, @param.
Comment #3
schoash commentedtested on 8.0.x and 8.1.x-dev.
It works on both and looks ok.
Comment #4
droplet commentedSorry, I forgot to mention it also on quickedit modules. We may have to change them all to keep consistent code in those files.
Comment #5
wim leersNo. Please don't change this. This variable is intentionally there, for legibility.
We don't do this for
#pre_rendercallbacks.s/format/text format/
LOL.
Omit the second line, please. The single-line explanation at the top of this docblock already covers this.
LOL. Needs to be fixed. This is useless.
Inaccurate.
Comment #6
heykarthikwithuComment #7
mac_weber commentedDid the changes pointed by @Wim Leers at #5, in addition to s/id/ID/ and:
Comment #8
wim leersJust two more nits, then this is RTBC:
Returns the in-place editor that quickedit selects.
Returns the selected in-place editor.
Comment #9
heykarthikwithuAs per #8, changes are done.
Comment #10
wim leersComment #11
alexpottAfaics there is one missing...
function editor_load($format_id) {every other function is either a hook or callback which don't need documentation.Comment #12
heykarthikwithuComment #13
heykarthikwithuAs per #11, changes are appended.
Comment #14
wim leersComment #15
alexpottCommitted 102928a and pushed to 8.0.x. Thanks!