options list in commerce_discount_rules_condition_info() uses function that doesn't exist

Thanks for the patch @chrisrockwell.

Here's a review: The nitpicks are for your reference, I'd have fixed them on commit if it was just those.

1. +++ b/sites/all/modules/commerce_discount/commerce_discount.inline_conditions.inc
   @@ -410,11 +410,7 @@ function commerce_order_has_specific_quantity_products_configure($settings) {
   +    '#options' => _inline_conditions_order_operator_options(),
   
   +++ b/sites/all/modules/commerce_discount/commerce_discount.rules.inc
   @@ -1420,6 +1420,17 @@ function _commerce_discount_operator_options() {
   +function _inline_conditions_order_operator_options() {
   

   Maybe we should use the existing _commerce_discount_operator_options?

2. +++ b/sites/all/modules/commerce_discount/commerce_discount.inline_conditions.inc
   @@ -650,4 +646,4 @@ function commerce_product_has_specified_terms_configure($settings) {
   -}
   +} ¶
   

   nitpick: white space at end of line added.

3. +++ b/sites/all/modules/commerce_discount/commerce_discount.rules.inc
   @@ -1420,6 +1420,17 @@ function _commerce_discount_operator_options() {
   -    '>=' => t('greater than or equal to'),
   +    '>=' => t('greater than or eq ual to'),
   

   Typo added

4. +++ b/sites/all/modules/commerce_discount/commerce_discount.rules.inc
   @@ -1420,6 +1420,17 @@ function _commerce_discount_operator_options() {
   + * Options list callback for condition
   

   Nit: all sentences with periods at the end.

Please if you post another patch set the status to "Needs Review". They get more attention with patches. https://www.drupal.org/node/156119#needs-review

Oh and make the patch relative to the commerce_discount modules. With git diff --relative flag

Sorry for being a dunce but I can't follow how the patch resolves the problem in the issue summary.

I wonder if there is a reason for not just using the same callback for the options list too.

Kinda hairy but I think I understand:)

I'd like to use the same callback actually for both. One reason is you will notice the default operator is '>=' for the commerce_order_has_specific_quantity_products condition. Which isn't available in that callback.

I just turned on the label and changed it to 'Quantity'. Also defaulted the the value to 1 because it's nothing and that's not good UX.

And needed to include the rules.inc file to get access to that function.

I've committed this to dev. Please download and give it a try. Re-open if I made a mistake.

We should probably put in a couple test cases to ensure this is working too. Thanks @chrisrockwell. I'll commit that in a moment. Just a quick note, the whitespace should likely be trimmed in your editor, most editors can do this on save for you. Sometimes they don't and it's accident (phpstorm save on same line for instance).

I'm fine re-opening this, it's an obvious oversight. Thanks for the patch!