Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Problem/Motivation
When text area with a summary has help text (description), button "Edit summary" is broken. Description html element has the same classes as text area element.
Proposed resolution
Specify jQuery selector only for textarea
element.
Remaining tasks
The patch is ready for review
Comment | File | Size | Author |
---|---|---|---|
#42 | interdiff-40-42.txt | 897 bytes | jofitz |
#42 | drupal-edit-summary-button-broken-2624496-42.patch | 4.99 KB | jofitz |
#40 | interdiff-38-40.txt | 742 bytes | jofitz |
#40 | drupal-edit-summary-button-broken-2624496-40.patch | 4.94 KB | jofitz |
#38 | interdiff-36-38.txt | 1.29 KB | jofitz |
Comments
Comment #2
zviryatko CreditAttribution: zviryatko at AnyforSoft commentedComment #3
swentel CreditAttribution: swentel commentedConfirmed, marking RTBC for now, maybe more eyes will see this.
Comment #4
droplet CreditAttribution: droplet commentedAttached a patch to fix the multiple textarea with summary in same page.
Also created a new issue to remove the class in textarea: #2649544: Remove '.text-full' in description of textarea with a summary
Comment #5
swetashahi CreditAttribution: swetashahi at Srijan | A Material+ Company commentedSteps followed to test
1. Launched a simplytest instance with latest patch
2. Created a custom content type with 2 text area and summary enabled
3. On trying to add a new content for the custom content type, for text areas no summary field shows up
4. Unable to test
Comment #6
swetashahi CreditAttribution: swetashahi at Srijan | A Material+ Company commentedComment #8
una_maria CreditAttribution: una_maria as a volunteer and at Amazee Labs commentedI've tested it and verified it's working. Steps followed to test:
Changed status to Needs review for someone else to double check it's working.
Comment #9
kryp71c CreditAttribution: kryp71c commentedComment #10
kryp71c CreditAttribution: kryp71c as a volunteer and commentedFollowed una_maria's steps to verify this:
This appears to be working correctly.
Changing the status to reviewed and tested.
Seeing as there is no way to edit the summary without the link the priority should be major. So, upgrading the priority.
Comment #11
kryp71c CreditAttribution: kryp71c commentedSomehow my previous comment vanished.
Tested the patch from Comment #2 based on una_maria's steps and it works also for multiple textarea fields.
It seems to me the patch from comment #2 is sufficient to fix the original issue.
Changing the status back to "Needs Review", until we can test the patch form comment #4
The priority was changed to major since there is no way to edit the summary without the "Edit Summary" links.
Comment #12
joelpittetThank you @una_maria and @kryp71c for pushing this issue forward at yesterdays sprint.
@una_maria could you post your stub test patch that you were working on yesterday? I'll gladly try to push this forward from that point. Or you can feel free to flush the test out further.
I found a blog post that shows how to get the JavaScript Functional tests up an running locally.
https://www.chapterthree.com/blog/javascript-testing-comes-to-drupal-8
@droplet the code in #4 seems like a bit more than needed to fix the issue. Could you add steps to reproduce so we can ensure we cover all the fixes/improvements you made from #2? With that detail we can incorporate that into the JS regression tests.
Comment #13
una_maria CreditAttribution: una_maria as a volunteer and at Amazee Labs commentedHi @joelpittet, here's the stub test. I am not sure what are the conventions for tests (naming, etc.), hopefully this is still useful.
Thank you very much for your help, I'll be very interested on checking your further work on this.
Comment #15
andrewmacpherson CreditAttribution: andrewmacpherson as a volunteer and at Annertech for Limerick City & County Council commentedThis patch combines those from comments #4 and #13, so we have the @droplet's fix and @una_maria's stub test in one patch.
Comment #17
andrewmacpherson CreditAttribution: andrewmacpherson as a volunteer and at Annertech for Limerick City & County Council commentedWhoops, ignore the files in comment #15. I uploaded an empty file.
This patch combines #4 (@droplet's fix) and #13 (@una_maria's stub test) in one patch
Comment #18
andrewmacpherson CreditAttribution: andrewmacpherson as a volunteer and at Annertech for Limerick City & County Council commentedComment #20
mohit_aghera CreditAttribution: mohit_aghera as a volunteer and at Axelerant commentedAdding basic test case related functions.
Comment #23
OwilliwOI have a look on this issue.
Provided patch fix problem, even in 8.3.x branch.
The problem is about provided tests.
Currently trying to understand what's wrong with it!
Comment #25
mohit_aghera CreditAttribution: mohit_aghera as a volunteer and at Axelerant commentedUpdating patch from #20 for 8.4.x
Comment #27
Munavijayalakshmi CreditAttribution: Munavijayalakshmi at Valuebound commenteduse short array syntax (new coding standard).
Fixed the short array syntax error and attached new patch.
.
Comment #29
mohit_aghera CreditAttribution: mohit_aghera as a volunteer and at Axelerant commentedFixing permission for access content.
Comment #31
Truptti CreditAttribution: Truptti at Axelerant commentedVerified the fix on Drupal 8.4.x-dev
1.Use latest drupal 8 version (8.4.x)
2.Add help text in Body field and reproduce the issue
3.Applied the patch 'drupal-edit-summary-button-broken-2624496-29.patch' in #29
4.The Edit Summary link is displayed on Body field with the Help text.
Attaching snapshot Before_patch_#29.png and After_patch_#29.png for reference
Comment #32
mohit_aghera CreditAttribution: mohit_aghera as a volunteer and at Axelerant commentedAttempt to fix testcase failures.
Comment #34
mohit_aghera CreditAttribution: mohit_aghera as a volunteer and at Axelerant commentedUpdating patch.
Comment #36
jofitz CreditAttribution: jofitz at ComputerMinds commentedComment #38
jofitz CreditAttribution: jofitz at ComputerMinds commentedIt may be worth investigating whether or not it is necessary to create and login as $admin_user (but my local test environment is not working so I'm taking this a step at a time).
Comment #40
jofitz CreditAttribution: jofitz at ComputerMinds commentedRemoved "click edit link" - there is no edit link to click!
Comment #42
jofitz CreditAttribution: jofitz at ComputerMinds commentedLet's try creating a node and then editing it.
Comment #44
idebr CreditAttribution: idebr commentedThis issue covers the same bug as #2626716: "Edit Summary" link not showing if "Help Text" is set
Comment #47
pminfSo closing this as duplicate of #2626716: "Edit Summary" link not showing if "Help Text" is set. This linked issue already has a patch with test coverage and there are only small changes to existing function compared to the patch provided here. But thank you anyway for your help, guys.