"Edit summary" button broken if text area with a summary has description

Confirmed, marking RTBC for now, maybe more eyes will see this.

Attached a patch to fix the multiple textarea with summary in same page.

Also created a new issue to remove the class in textarea: #2649544: Remove '.text-full' in description of textarea with a summary

Steps followed to test
1. Launched a simplytest instance with latest patch
2. Created a custom content type with 2 text area and summary enabled
3. On trying to add a new content for the custom content type, for text areas no summary field shows up
4. Unable to test

I've tested it and verified it's working. Steps followed to test:

1. Pull latest Drupal version (8.2.x) to my local instance.
2. Reproduce issue: add help text to Basic page's body, verify that Edit summary link doesn't display anymore.
3. Apply patch #2 (drupal-edit-summary-button-broken-2624496.patch).
4. Rebuild caches.
5. Verify that Edit summary link displays and works as expected.

Changed status to Needs review for someone else to double check it's working.

Followed una_maria's steps to verify this:

1. Use latest drupal 8 version (8.2.x)
2. Reproduced issue: edit body content type to add some help text -> add content basic page "Edit Summary" link is missing
3. Applied patch from comment #2
4. Rebuild cache
5. "Edit Summary" link is now visible on add content basic page with help text
6. Also tested this with two textarea fields. Still works.

This appears to be working correctly.
Changing the status to reviewed and tested.
Seeing as there is no way to edit the summary without the link the priority should be major. So, upgrading the priority.

Somehow my previous comment vanished.
Tested the patch from Comment #2 based on una_maria's steps and it works also for multiple textarea fields.

It seems to me the patch from comment #2 is sufficient to fix the original issue.

Changing the status back to "Needs Review", until we can test the patch form comment #4
The priority was changed to major since there is no way to edit the summary without the "Edit Summary" links.

Thank you @una_maria and @kryp71c for pushing this issue forward at yesterdays sprint.

@una_maria could you post your stub test patch that you were working on yesterday? I'll gladly try to push this forward from that point. Or you can feel free to flush the test out further.

I found a blog post that shows how to get the JavaScript Functional tests up an running locally.
https://www.chapterthree.com/blog/javascript-testing-comes-to-drupal-8

@droplet the code in #4 seems like a bit more than needed to fix the issue. Could you add steps to reproduce so we can ensure we cover all the fixes/improvements you made from #2? With that detail we can incorporate that into the JS regression tests.

Hi @joelpittet, here's the stub test. I am not sure what are the conventions for tests (naming, etc.), hopefully this is still useful.

Thank you very much for your help, I'll be very interested on checking your further work on this.

This patch combines those from comments #4 and #13, so we have the @droplet's fix and @una_maria's stub test in one patch.

Whoops, ignore the files in comment #15. I uploaded an empty file.

This patch combines #4 (@droplet's fix) and #13 (@una_maria's stub test) in one patch

Adding basic test case related functions.

I have a look on this issue.
Provided patch fix problem, even in 8.3.x branch.
The problem is about provided tests.
Currently trying to understand what's wrong with it!

Updating patch from #20 for 8.4.x

+++ b/core/modules/text/tests/src/FunctionalJavascript/TextIntegrationTest.php
@@ -0,0 +1,59 @@
+    $node = array(
+      'title' => $title,
+      'body' => array(array('value' => $this->randomMachineName(32))),
+      'uid' => $this->webUser->id(),
+      'type' => 'article',
+    );
...
+    $edit = array();

use short array syntax (new coding standard).

Fixed the short array syntax error and attached new patch.
.

Fixing permission for access content.

Verified the fix on Drupal 8.4.x-dev
1.Use latest drupal 8 version (8.4.x)
2.Add help text in Body field and reproduce the issue
3.Applied the patch 'drupal-edit-summary-button-broken-2624496-29.patch' in #29
4.The Edit Summary link is displayed on Body field with the Help text.
Attaching snapshot Before_patch_#29.png and After_patch_#29.png for reference

Attempt to fix testcase failures.

Updating patch.

1. Added $webUser.
2. Tried to avoid permissions error by first creating the page content type.
3. Use $this->createNode() rather than Node::create().
4. Inline some redundant variables.
5. Replace deprecated assertion method.

1. Replaced $this->webUser with simply $user.
2. Replaced $this->createNode() with $this->drupalGet().

It may be worth investigating whether or not it is necessary to create and login as $admin_user (but my local test environment is not working so I'm taking this a step at a time).

Removed "click edit link" - there is no edit link to click!

Let's try creating a node and then editing it.

This issue covers the same bug as #2626716: "Edit Summary" link not showing if "Help Text" is set

So closing this as duplicate of #2626716: "Edit Summary" link not showing if "Help Text" is set. This linked issue already has a patch with test coverage and there are only small changes to existing function compared to the patch provided here. But thank you anyway for your help, guys.