"Edit Summary" link not showing if "Help Text" is set

Hi,

Did you enable the "Summary input" checkbox for your field on the field settings form?

I'm having the opposite problem. The Page body field is "Long text with summary", and despite un-checking the "Summary input" box, saving, and flushing caches, the summary field still shows when editing a page.

Reported mine here: https://www.drupal.org/node/2757935

+1 Same issue.

When entering text into the "Help Text" field of a body field with type Text (formatted, long, with summary) in any content type, the "Edit Summary" link disappears on edit pages.

I tried with "Summary input" checked, making the field required and not required. Verified on all of my content types. Rebuilt cache, still not working.

Looks like a JavaScript is not properly displaying the "Edit Summary" link as described in the original issue.

Did you have any js errors in console?

Indeed this bug exist and it caused by the description field CSS classes "js-text-full text-full" which are used in the text.js. I will provide patch to fix js, but will need to figure out where those classes were added, only Formatted fields have this.

There is a patch which fix text.js to find correct label.

+++ b/core/modules/text/text.js
@@ -22,7 +22,7 @@
+        var $full = $widget.find('.js-text-full').closest('.text-format-wrapper .js-form-item');

I think this can be simper if we just look for children in $widget. Also, assigning to myself to have a go at writing a test.

The full value sub-field is a direct descendant of the wrapper so I've selected it with:

$widget.children('.js-form-type-textarea');

Attached are test-only and full patches that apply cleanly to 8.1.x, 8.2.x and 8.3.x. No interdiff because the fix is only one line.

Turns out git add -N doesn't work for making patches.

The last patched left in a createScreenshot() call.

I think this can be simper if we just look for children in $widget. Also, assigning to myself to have a go at writing a test.

Kudos for writing those tests! Great to see people picking it up.

1. +++ b/core/modules/text/tests/src/FunctionalJavascript/TextareaWithSummaryTest.php
   @@ -0,0 +1,86 @@
   +    $this->drupalGet('/node/add/page');
   

   Nitpick: We usually don't prepend this path with a slash.

2. +++ b/core/modules/text/tests/src/FunctionalJavascript/TextareaWithSummaryTest.php
   @@ -0,0 +1,86 @@
   +    $this->summaryToggleHelper();
   

   I'm wondering whether you can think of a better name for this function. Maybe assertSummaryToggle?

1. Fixed, thanks.
2. I can't think of a better name than assertSummaryToggle, so going with your suggestion!

This fixed the issue for me too, thanks!

The fix works.

I updated the test to avoid the assertTrue() calls, the Trait these functions are in is deprecated and on track to be removed for 9.x.

One doubt I have: Does it need a test for 2 fields with summaries on 1 page. The behavior should work for both but it's not tested right now. Another test I just made (#2821320) actually exposed a potential error with 2 elements.

This post helped A LOT!

I was wondering why I did not see the 'Edit Summary' link on the long-text-with-summary field.
Aha! So it was the help text - Thanks a lot.

Have a great day

#22 fixed it for me on 8.3.

Just re-rolled, plus
Update text.es6.js file
Fix array syntax in test file.

The patch still applies on 8.5.x and it fixes the issue.

Thanks guys!

Thanks for working on this!

+++ b/core/modules/text/tests/src/FunctionalJavascript/TextareaWithSummaryTest.php
@@ -0,0 +1,86 @@
+    // Repeat test with non-empty field description.
+    // @see https://www.drupal.org/node/2626716

We shouldn't link issue the issue node in the codebase; it's discoverable with git blame. If there's information on this node that someone actually should have when reading this code, then we should put that information in the comment directly. And if they don't actually need the information, then we shouldn't send them on a wild goose chase to the sprawling thread of an issue. :)

Removed the comment as per #32

I think this was RTBC status, and just a comment was deleted, so it seems it should go back to RTBC. In addition, I ran into this exact same issue and am using this patch to fix the problem... so 2x RTBC. =)

Temporary testbot hiccup.

It may be worth crediting some of the people on #2624496: "Edit summary" button broken if text area with a summary has description (not me, though) because they worked hard on the same problem and had tests as well and was opened a few days earlier.

Crediting those who worked on #2624496: "Edit summary" button broken if text area with a summary has description

Creditting @dawehner for the review.

Committed and pushed 4b9a1216b5 to 8.6.x and d653a9ce37 to 8.5.x. Thanks!