If I view a URL like admin/structure/features/<feature_name>/diff and there are no overrides, I get an access denied error. Instead, I should get a message stating that there are no overrides.

CommentFileSizeAuthor
#3 access_denied_when_no_diff_2623926_3.patch659 bytesdpovshed

Comments

Liam Morland created an issue. See original summary.

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Issue summary: View changes
dpovshed’s picture

dpovshed commented
Status: Active » Needs review
StatusFileSize
new access_denied_when_no_diff_2623926_3.patch659 bytes

I also spotted this issue in one of my projects, so here is the patch.

The patch does the following:
- access is allowed if there are no changes in feature;
- removed extra call to the user_access() function - it was called twice with the same arguments.

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Status: Needs review » Reviewed & tested by the community

Thanks. Working for me.

donquixote’s picture

donquixote commented

Just saying I support this.

Maybe it could be useful to display the status in the title of the "Diff" tab. Using the title callback.
This way, people avoid to open this tab if there is nothing to see.
But I can live without this. Main thing is that access is not denied.

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented

The diff tab doesn't show up if there are no differences. The main thing for this is if I have the diff tab open, make changes or update the code, and then reload the diff tab.

  • mpotter committed 2eaf9ec on 7.x-2.x authored by dpovshed 
    Issue #2623926 by dpovshed: Access denied when viewing diff page when...
mpotter’s picture

mpotter commented
Status: Reviewed & tested by the community » Fixed

Committed to 2eaf9ec.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.