Thank you for your module, I tried it on my local server but run into troubles. My server returns ip address like "::1" (MAMP PRO on Mac OS X) but it's more general problem, think about someone who uses IPv6? Function ip2long() returns nothing and your module causes error (because IP address column cannot be empty). I think fix is simple, just save ip address as string. Could you look into this? Thanks in advance.

CommentFileSizeAuthor
#3 is-there-any-reason-to-save-IP-address-as-integer.2623886.3.patch3.31 KBwuinfo - bill wu

Comments

parisek created an issue. See original summary.

wuinfo - bill wu’s picture

wuinfo - bill wu commented

IPv6 was not in the consideration when developing this module. Thanks for the report. I will address this issue soon I got some time.

wuinfo - bill wu’s picture

wuinfo - bill wu commented
StatusFileSize
new is-there-any-reason-to-save-IP-address-as-integer.2623886.3.patch3.31 KB

Here is the patch. Before applying the patch, please, disable and uninstall the module.

parisek’s picture

parisek
Primary language Czech
commented

Patch works great :)

  • wuinfo committed 05d15dc on 7.x-1.x 
    Issue #2623886 by wuinfo: Is there any reason to save IP address as...
wuinfo - bill wu’s picture

wuinfo - bill wu commented
Status: Active » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.