Heya,

Including next_serial when rendering feature module will always display an overridden status b/c this value will constantly change with additional webform submissions.

I'm not quite sure the best way to manage this, should we also exclude this during export?

CommentFileSizeAuthor
#4 webform_features-exclude-next-serial-2623112-4.patch513 bytesmiteshmap
#2 webform_features-exclude-next-serial-2623112-2.patch512 bytesjasonawant

Comments

jasonawant created an issue. See original summary.

jasonawant’s picture

jasonawant
he/him
Primary language English
Location New Orleans, USA
commented
Status: Active » Needs review
StatusFileSize
new webform_features-exclude-next-serial-2623112-2.patch512 bytes

Here's a patch that excludes this during rendering.

duaelfr’s picture

duaelfr
he/him
Primary language French
Location Montpellier, France
commented

Good job, thank you.
I just gave you the rights to maintain the module so you can commit your two patches and the future ones.
Thank you again for your help, that's much appreciated :)

miteshmap’s picture

miteshmap
Primary language Gujarati
commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new webform_features-exclude-next-serial-2623112-4.patch513 bytes

@jasonawant - It's a good idea. Missing semicolon at the end of the line, attached new patch with semicolon.

  • miteshmap committed 36301e2 on 7.x-4.x 
    Issue #2623112 by jasonawant, miteshmap: next_serial value throws...
miteshmap’s picture

miteshmap
Primary language Gujarati
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.