Our server doesn't seem to allow cURL connections. Furthermore it seems to be recommended to use the native drupal_http_request function instead of cURL.

CommentFileSizeAuthor
#5 minify-drupal_http_request-2622146-5.patch1.93 KBsgdev
#2 drupal_http_request_instead_of_curl-2622146-1.patch1.5 KBlolandese

Comments

lolandese created an issue. See original summary.

lolandese’s picture

lolandese commented
Status: Active » Needs review
Related issues: +#2402737: Allow using a local Google Closure Compiler binary
StatusFileSize
new drupal_http_request_instead_of_curl-2622146-1.patch1.5 KB

We rolled the #2 suggestion in #2402737: Allow using a local Google Closure Compiler binary into a patch. Seems to work as expected.

lolandese’s picture

lolandese commented

If you would like to also retain cURL we could do something like:

if (ini_get('allow_url_fopen') && function_exists('curl_version')) {
  OFFER RADIOS TO CHOOSE BETWEEN ONE OR THE OTHER
}
elseif (ini_get('allow_url_fopen')) {
  USE DRUPAL_HTTP_REQUEST
}
elseif (function_exists('curl_version')) {
  USE CURL
}
else {
  ERROR: YOUR SERVER HAS TROUBLE TO CONNECT TO THE GOOGLE COMPILER
}
jenlampton’s picture

jenlampton
she / her
commented
Status: Needs review » Reviewed & tested by the community

Works for me, RTBC.

sgdev’s picture

sgdev commented
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new minify-drupal_http_request-2622146-5.patch1.93 KB

Cannot be RTBC. Does not match the code in -dev, and patch #2 references "http" for the compiler when it has already been updated in the module to "https". See attached.