On columns where NULL is permitted, the column comment should state what it means for the column to be NULL.

CommentFileSizeAuthor
#4 election-document_nulls-2621482-4-D7.patch6.77 KBliam morland
#2 election-document_nulls-2621482-2-D7.patch5.43 KBliam morland

Comments

Liam Morland created an issue. See original summary.

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Status: Active » Needs review
StatusFileSize
new election-document_nulls-2621482-2-D7.patch5.43 KB

This patch is designed to be committed after the patch in #2615130: Set many database columns NOT NULL and will fail tests until then. With this patch, every column should be either NOT NULL or have a description of what it means when the column is NULL. Please check that the descriptions are correct.

Status: Needs review » Needs work

The last submitted patch, 2: election-document_nulls-2621482-2-D7.patch, failed testing.

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Status: Needs work » Needs review
StatusFileSize
new election-document_nulls-2621482-4-D7.patch6.77 KB

Reroll. This and other the schema changes can be seen in the Git repository in the branch db-schema-changes. This patch must be applied after the patch in #2615130: Set many database columns NOT NULL.

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Assigned: Unassigned » liam morland
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.