in .cron.inc _scheduler_unpublish() fatal errors are caused when getting our date values from the $node. $unpublish_on = $node->unpublish_on needs to be $node->unpublish_on->value
This has already been fixed in _scheduler_publish() but in _scheduler_unpublish() it got missed.

CommentFileSizeAuthor
#3 use_value_for-2621122-3.patch1.32 KBjoekers

Comments

jonathan1055 created an issue. See original summary.

jonathan1055’s picture

jonathan1055 commented
Priority: Normal » Major
Issue summary: View changes

Upping priority because this actually means unpublishing does not work at all. Anyone can work on this, but if no patches arrive during the day I can fix it this evening.

joekers’s picture

joekers
Primary language English
commented
Assigned: Unassigned » joekers
Status: Active » Needs review
StatusFileSize
new use_value_for-2621122-3.patch1.32 KB

Also fixed the publish_on line in _scheduler_unpublish().

  • jonathan1055 committed 9359015 on 8.x-1.x authored by joekers 
    Issue #2621122 by joekers, jonathan1055: Use ->value for $node->...
jonathan1055’s picture

jonathan1055 commented
Status: Needs review » Fixed

Thanks alot. Good work.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Status: Closed (fixed) » Needs work

The last submitted patch, 3: use_value_for-2621122-3.patch, failed testing.

jonathan1055’s picture

jonathan1055 commented
Assigned: joekers » Unassigned
Status: Needs work » Closed (fixed)

Ignore the failed patch above. It was queued but not run until the 8.x committed codebase passed all tests. That happened with my commit a few minutes ago, and then the untested patches have suddenly come to life and been run. This issue is already fixed.