Closed (fixed)
Project:
Message
Version:
7.x-1.x-dev
Component:
Code
Priority:
Major
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
20 Nov 2015 at 23:45 UTC
Updated:
21 Jun 2018 at 18:09 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
Neo13 commentedI guess solution is as simple as adding curly brackets on line 167 in message.message_type.inc
Please review and commit if OK.
Comment #3
neclimdulYou probably want to read this https://wiki.php.net/rfc/uniform_variable_syntax
Comment #4
Neo13 commentedI sure did. Is my solution wrong?
Comment #5
neclimdulNo, sorry that looks like its probably correct without the context of the original code. Just wanted to link to the documentation for why it was failing to make sure it was being resolved correctly.
Comment #6
klausiNeeds a patch.
Comment #7
joelpittetUsing this as my guide: https://blog.engineyard.com/2015/what-to-expect-php-7
This patch covers all the
->$Comment #8
amitaibu@joelpittet thanks. Just to confirm, is this patch tested on PHP7?
Comment #9
joelpittet@amitaibu yes:) Got php70 running with homebrew yesterday to give it a spin, that's why I'm here;)
Comment #10
neclimdulThese should resolve the same. The change in 7 was order of operations but there's nothing like that going on here.
If I'm reading this correctly this should resolve the same too.
https://3v4l.org/CBZtU
Comment #11
joelpittetYes @neclimdul you are right, though does it hurt to be explicit and consistent everywhere?
Comment #12
Anonymous (not verified) commentedAlso seeing this error when I run one of my sites in php7, it renders the site unreachable.
@joelpittet's patch in #7 fixes it.
Comment #13
joelpittet@ryan weal it did! It was fat along out and after that it let me use php7.
Not all of the patch is nessasary I just covered everything with the same explicit fix.
Comment #15
amitaibumerged, thanks.
btw, I'm about to soon close this issue queue in favor of the GitHub one
Comment #16
amitaibuA new release will be published shortly :)
Comment #18
tomrogPatch #7 works very well - big thanks :)
I was surprised to see usage of variables without { } :O Anyway, someone could put this into official version, because I think currently more and more people will update PHP version :)
Comment #19
amitaibuIt is already part of Message - https://www.drupal.org/node/2639122
Comment #20
tomrogRight, my bad :) I thought one of my coworkers has made updates since Decemeber - guess I was wrong. Sorry for misunderstanding :D
Comment #21
Abbass commentedCan anybody help patch this code, I am getting an error EntityMetadataWrapperException : Unknown data property Array. In EntityStructureWrapper->getPropertyInfo() (line 354 in entity.wrapper.inc), I am pasting the code from entity wrapper here, I have PHP 7. Trying the patch bracket on line 353, fixes the problem but right after the site breaks with an illegal syntax error referring to the modified line. The code is also availabe in the attached text file.