Allow pages to have menu items

now wizard landed, and patch outdated

This would be a great feature to have indeed. I thought I had a bug until I ran into this issue.

Rebased for 4.x branch.

The form was not working at all, I make it 'work' but it does not save the form, I get an error:
Warning: call_user_func_array() expects parameter 1 to be a valid callback, class 'normal_menu' not found in Drupal\Core\Form\FormValidator->executeValidateHandlers() (line 82 of core/lib/Drupal/Core/Form/FormValidator.php).
Where 'normal_menu' takes the value of the selected menu type.
If I comment in FormBuilder.php the line 262 where the form is retrieved from the cache $form = $this->getCache($input['form_build_id'], $form_state); then it works fine, but obviously I can't do that, so any help is appreciated.
Also the menu forms are a bit messy, the only that works fine is the normal menu I think, and is missing functionality like delete menu, enable/disable, and much more.

Rebased.
Use none instead of route when there is no menu.
Make menu deletable.

I ran into caching issues when using access conditions on the routes. Attached patch fixes them pretty much like how the block module does it. Not super happy about two foreach()-loops, could probably be simplified.

Patch no longer applied, so rerolled. Updated the patch to no loger log when catching the UnexepectedValueException in Url::getRouteName() as it's not an error per se and the log was getting spammed.

Was testing and doesn't work on pages with a token in the URL.

E.g. url: /user/{user}/admin

Note

Having looked views doesn't support this either and says "Views cannot create normal menu items for paths with a % in them."

So this should say "Page Manager cannot create normal menu items for paths with a parameter in them."

Tried this patch against 9.2.2 and got the following:

he website encountered an unexpected error. Please try again later.

Symfony\Component\DependencyInjection\Exception\ServiceNotFoundException: You have requested a non-existent service "user.shared_tempstore". in Drupal\Component\DependencyInjection\Container->get() (line 156 of core/lib/Drupal/Component/DependencyInjection/Container.php).

Drupal\page_manager_ui\Form\PageMenuForm::create(Object) (Line: 28)
Drupal\Core\DependencyInjection\ClassResolver->getInstanceFromDefinition('\Drupal\page_manager_ui\Form\PageMenuForm') (Line: 238)
Drupal\ctools\Wizard\FormWizardBase->getFormId() (Line: 205)
Drupal\Core\Form\FormBuilder->getFormId(Object, Object) (Line: 227)
Drupal\Core\Form\FormBuilder->buildForm(Object, Object) (Line: 57)
Drupal\ctools\Wizard\WizardFactory->getWizardForm(Object, Array, ) (Line: 78)
Drupal\ctools\Controller\WizardFormController->getContentResult(Object, Object)
call_user_func_array(Array, Array) (Line: 123)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 578)
Drupal\Core\Render\Renderer->executeInRenderContext(Object, Object) (Line: 124)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext(Array, Array) (Line: 97)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 158)
Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object, 1) (Line: 80)
Symfony\Component\HttpKernel\HttpKernel->handle(Object, 1, 1) (Line: 57)
Drupal\Core\StackMiddleware\Session->handle(Object, 1, 1) (Line: 47)
Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object, 1, 1) (Line: 106)
Drupal\page_cache\StackMiddleware\PageCache->pass(Object, 1, 1) (Line: 85)
Drupal\page_cache\StackMiddleware\PageCache->handle(Object, 1, 1) (Line: 47)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object, 1, 1) (Line: 52)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object, 1, 1) (Line: 23)
Stack\StackedHttpKernel->handle(Object, 1, 1) (Line: 717)
Drupal\Core\DrupalKernel->handle(Object) (Line: 19)

Suggestions?

user.shared_tempstore was renamed to tempstore.shared in #2935617: Move User module's temp stores to core (January 2018!) and the BC layer was removed in D9

+++ b/src/Plugin/PageManagerMenu/NormalMenu.php
@@ -0,0 +1,102 @@
+    $menus = [];
+    foreach ($this->menuStorage->loadMultiple() as $id => $menu) {
+      $menus[$id] = $menu->label();

it could use views' approach, like #3021804: Remove optional dependency on menu_ui module in \Drupal\views\Plugin\views\wizard\WizardPluginBase

This patch just fixes deprecated dependencies for D9, I still need to take a deeper look at the issue with views.

When I try to create a page with a menu or go back to add a menu item I get the following on Drupal 9.2.7:

The website encountered an unexpected error. Please try again later.
TypeError: Argument 2 passed to Drupal\page_manager_ui\Form\PageMenuForm::__construct() must be an instance of Drupal\user\SharedTempStoreFactory, instance of Drupal\Core\TempStore\SharedTempStoreFactory given, called in /home/sites/sitename/public_html/modules/contrib/page_manager/page_manager_ui/src/Form/PageMenuForm.php on line 31 in Drupal\page_manager_ui\Form\PageMenuForm->__construct() (line 34 of modules/contrib/page_manager/page_manager_ui/src/Form/PageMenuForm.php).

Drupal\page_manager_ui\Form\PageMenuForm->__construct(Object, Object) (Line: 31)
Drupal\page_manager_ui\Form\PageMenuForm::create(Object) (Line: 28)
Drupal\Core\DependencyInjection\ClassResolver->getInstanceFromDefinition('\Drupal\page_manager_ui\Form\PageMenuForm') (Line: 238)
Drupal\ctools\Wizard\FormWizardBase->getFormId() (Line: 205)
Drupal\Core\Form\FormBuilder->getFormId(Object, Object) (Line: 227)
Drupal\Core\Form\FormBuilder->buildForm(Object, Object) (Line: 57)
Drupal\ctools\Wizard\WizardFactory->getWizardForm(Object, Array, ) (Line: 78)
Drupal\ctools\Controller\WizardFormController->getContentResult(Object, Object)
call_user_func_array(Array, Array) (Line: 123)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 578)
Drupal\Core\Render\Renderer->executeInRenderContext(Object, Object) (Line: 124)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext(Array, Array) (Line: 97)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 158)
Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object, 1) (Line: 80)
Symfony\Component\HttpKernel\HttpKernel->handle(Object, 1, 1) (Line: 57)
Drupal\Core\StackMiddleware\Session->handle(Object, 1, 1) (Line: 47)
Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object, 1, 1) (Line: 106)
Drupal\page_cache\StackMiddleware\PageCache->pass(Object, 1, 1) (Line: 85)
Drupal\page_cache\StackMiddleware\PageCache->handle(Object, 1, 1) (Line: 50)
Drupal\ban\BanMiddleware->handle(Object, 1, 1) (Line: 47)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object, 1, 1) (Line: 52)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object, 1, 1) (Line: 23)
Stack\StackedHttpKernel->handle(Object, 1, 1) (Line: 717)
Drupal\Core\DrupalKernel->handle(Object) (Line: 19)

Suggestions?

Is this something that is actively being supported or looked into?

Does anyone have this working? I am using the latest dev, create a layout page, add it to the main menu save the page. I then flush the cache and no menu entry is generated and when I go to check the menu definition within page manager it defaults to the user menu even though there is no menu entry.

Suggestions?

Changed some code from #25 since it broke my normal menu links, the derivative manager was only adding default_menu_tab and menu_tab items to the array of derivatives, as well as some inconsistent usage of the keys "menu" and "menu_name" causing some further issues.

I've also used core's menu link overrides to move some menu links around. With #25, none were applied. When I tried to update some values, the call to updateMenuLink caused a WSOD due to it trying to set the values directly to on page entity (i.e. $page->weight->value) which obviously doesn't exist. Should these overrides even be written directly to the page entity? Why not do what core does where menu link overrides are saved in a separate config entry? makes more sense IMO.

Patch #27 work, but I can't select menu item 2 level for my page. Only menu 1 level

Rolled patch from #27 that is compatible with 4.0.0-rc2.

Patch #29 fails