Convert all get_called_class()/get_class() to static::

Sorry if I misunderstand the purpose of this old issue. I was about to create one with basically the same subject, before looking it up. I think that the problem was (and is) valid; the approach just wasn't right.

We can't use the keyword 'static' inside a string, since it will not be resolved correctly. Instead of replacing [get_called_class(), 'method'] with 'static::method' the patch should have replaced it with static::class . '::method', which is indeed already used in a lot of places in core.

Per this StackOverflow answer, get_called_class() is fully identical to static::class (in PHP 5.5+), and the latter has a minor performance benefit.

in 9.0.x, get_called_class() is still used in 18 files (14 of them in the form [get_called_class(), '...'] ), while static::class is used in 51 files (11 of them in the form static::class . '::...').
Just for consistency (if negligible performance), we might want to look at this again.

Bad patch.

This one replaces get_called_class() with static::class everywhere.

A further replacement we might consider is replacing static::class . '::method' with [static::class, 'method'] everywhere. The two are semantically equivalent and the latter is used far more commonly in core.

get_class($this) can also be replaced with static::class.

(There is no such replacement for get_class() in general.)

Talked to @alexpott on slack about this issue. He is ok with both changes: get_called_class() to static::class and get_class($this) to static::class.
The IS needs an update.

The changes in the patch look good. But when I do a code base search for "get_class($this)" I still get a 167 results after I applied the patch.

I am working on this.

The webdriver tests have always been a bit brittle, might be a random failure. Retesting.

The patch is applied successfully and looks good to be merged.

Updated the IS.

Confirmed that all changes in the patch replace instances of 'get_called_class()/get_class($this) with static::class, and that there aren't any of them left after applying it.

Needs a re-roll.

Working on this.

Added reroll of patch #14.

1. Attaching a raw-interdiff.txt file.

2. $ grep -r get_called_class core composer --exclude-dir=core/node_modules
   [no output]
   $ grep -r 'get_class($this)' core composer --exclude-dir=core/node_modules
   [no output]
   

   No leftovers.

Committed eafefd8 and pushed to 9.1.x. Thanks!