Support exporting D8 backups, but without breaking aegir_backup_export_path

When running this - I did not experience "backup fine". There was no backup in the appropriate directory.

FYI there is only one function in this entire file... There's a better way to do this, for sure...

Looking into it.

/**
 * @file
 * Helper functions.
 */

/**
 * Helper function to get the root directory where backups are exported.
 */
function _hosting_site_backup_manager_get_backup_export_root() {
  $root = variable_get('hosting_site_backup_manager_export_root', '/var/aegir/backup-exports');
  return $root;
}

If someone can take this all you have to do is:L

1. Remove hosting_site_backup_manager.inc.
2. Search and replace:

_hosting_site_backup_manager_get_backup_export_root();

for

drush_get_option('aegir_backups_path', '/var/aegir/backup-exports');

Not sure if there was a reason for the include and the helper function. Maybe someone wanted the site itself to define it's own backup path?

Patch attached!

Better patch. This one uses variable_get() when appropriate... I think :)

needs a little more testing, will get back to you.

Seems to work, with a warning:

include_once(/var/aegir/hostmaster-7.x-3.3/profiles/hostmaster/modules/aegir/hosting_site_backup_manager/drush/../hosting_site_backup_manager.inc): failed to open stream: No such file or directory hosting_site_backup_manager.drush.inc:58	
-
include_once(): Failed opening '/var/aegir/hostmaster-7.x-3.3/profiles/hostmaster/modules/aegir/hosting_site_backup_manager/drush/../hosting_site_backup_manager.inc' for inclusion (include_path='.:/usr/share/php:/usr/share/pear') hosting_site_backup_manager.drush.inc:58

This is the line: include_once dirname(__FILE__) . '/../hosting_site_backup_manager.inc';

Did we just forget to remove it? It doesn't seem to do anything.

Marking as "needs work" just in case, but for those in a hurry I can confirm the current patch (#7) will do the job.

Ah, I didn't see that one. Funny, the include statement appeared. twice. New patch attached!

Thanks, I tested and committed your patch. You rock.

This change breaks support for aegir_backup_export_path variable completely. There reason the helper file was in place, is that otherwise the backend couldn't access aegir_backup_export_path variable, which is stored in the database, and against assumption here, is not stored anywhere as a drush option, so the only method to access it is via _hosting_site_backup_manager_get_backup_export_root() wrapper, or variable_get() directly.

In short, this code will always default to /var/aegir/backup-exports, but you will never notice this, unless your Aegir root is different than /var/aegir, like it is in every BOA instance.

$backupdir = drush_get_option('aegir_backup_export_path', '/var/aegir/backup-exports');

Attached is a working workaround. Note that it only hides the problem, because aegir_backup_export_path is not used here anyway. By the way, how are we supposed to be able to use this variable, if it is not set anywhere in the code? There is just no such variable and no such drush option anywhere.

And there is still one, now useless line:

include_once dirname(__FILE__) . '/../hosting_site_backup_manager.inc';