Comments

j2r created an issue. See original summary.

sagar ramgade’s picture

Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, fieldable_panels_panes_broken_links.patch, failed testing.

Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, fieldable_panels_panes_broken_links.patch, failed testing.

milodesc’s picture

Status: Needs work » Needs review
StatusFileSize
new881 bytes

I'm seeing the same issue on a site that I work on. So, I wanted to try this fix out. I installed FPP on a clean drupal install and did not see the issue. The "Manage Fields" and "Manage Display" links worked just fine.

After taking a closer look at the site that was experiencing the issue, I noticed that we're creating bundles via hook_entity_info_alter() as detailed in FPP's README.txt. README.txt instructs you to create your bundles with the following:

function MYMODULE_entity_info_alter(&$entity_info) {
  $entity_info['fieldable_panels_pane']['bundles']['my_bundle_name'] = array(
    'label' => t('My bundle name'),
    'pane category' => t('My category name'),
    'pane top level' => FALSE, // set to true to make this show as a top level icon
    'pane icon' => '/path/to/custom/icon/for/this/pane.png',
    'admin' => array(
      'path' => 'admin/structure/fieldable-panels-panes/manage/%fieldable_panels_pane_type',
      'bundle argument' => 4,
      // Note that this has all _ replaced with - from the bundle name.
      'real path' => 'admin/structure/fieldable-panels-panes/manage/my-bundle-name',
      'access arguments' => array('administer fieldable panels panes'),
    ),
  );
}

Note the paths in the code above begin with 'admin/structure/fieldable-panels-panes/manage/'. Perhaps the better option is to shorten that to 'admin/structure/fieldable-panels-panes/' when creating bundles? That seems to have fixed the issue on my site without patching the module.

Maybe an alternate solution is to fix the README.txt to not include 'manage' in the path? This won't fix bundles that have already been created with manage in the path, but maybe it'll prevent future issues.

Patch to the README.txt attached. This change would make the README.txt instructions consistent with how bundles are created in fieldable_panels_panes.module's fieldable_panels_panes_entity_info function.

j2r’s picture

Status: Needs review » Needs work

Thanks milodesc.

It helps. Just one more small correction is require in README.txt

'bundle argument' => 3,
milodesc’s picture

Status: Needs work » Needs review
StatusFileSize
new912 bytes

Cool. I've updated the bundle argument in the latest patch.

j2r’s picture

Status: Needs review » Reviewed & tested by the community
robloach’s picture

Yup.

damienmckenna’s picture

Version: 7.x-1.7 » 7.x-1.x-dev
Status: Reviewed & tested by the community » Fixed

Committed. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.