Problem/Motivation

Taxonomy vocabulary have a required settings. We should migrate this settings to the field instance.

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#5 2618804-5.patch2.85 KBwebflo
#2 2618804-2.patch2.85 KBwebflo

Comments

webflo created an issue. See original summary.

webflo’s picture

webflo commented
Status: Active » Needs review
StatusFileSize
new 2618804-2.patch2.85 KB
webflo’s picture

webflo commented 
+++ b/core/modules/taxonomy/src/Tests/Migrate/d6/MigrateVocabularyFieldInstanceTest.php
@@ -53,6 +55,11 @@ public function testVocabularyFieldInstance() {
+    // Test the the field vocabulary_1_i_0_
...
+    $this->assertTrue($field->isRequired(), 'Field is not required');

Should fail, because vocabulary_1_i_0_ is not required. The assertion in wrong.

Status: Needs review » Needs work

The last submitted patch, 2: 2618804-2.patch, failed testing.

webflo’s picture

webflo commented
Issue summary: View changes
Status: Needs work » Needs review
StatusFileSize
new 2618804-5.patch2.85 KB
mikeryan’s picture

mikeryan
he/him
Primary language English
Location Pittsfield, MA, USA
commented

I'm confused, this looks redundant with #2618830: Term widget migration should depend on tags property?

webflo’s picture

webflo commented

Sorry, i uploaded the wrong patch in #2618830: Term widget migration should depend on tags property.

webflo’s picture

webflo commented
Issue tags: +SprintWeekendBerlin
jan.stoeckler’s picture

jan.stoeckler
he/his
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

This works well, as far as I can tell.

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.1.x and cherry-picked to 8.0.x. Thanks!

  • catch committed 4497608 on 8.1.x 
    Issue #2618804 by webflo: Migrate required setting from vocabulary to...

  • catch committed ae518ad on 
    Issue #2618804 by webflo: Migrate required setting from vocabulary to...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.