In search_config_permission:


/**
 * Implements hook_permission().
 */
function search_config_permission() {
  $permissions = array(
    'admin node search exlusions' => array(

exlusions => exclusions

CommentFileSizeAuthor
#9 interdiff-2618222-3-9.txt541 bytesnaveenvalecha
#9 2618222-9.patch1.39 KBnaveenvalecha
#3 PermissionSpell-2618222-3.patch881 bytesjoyceg

Comments

djdevin created an issue. See original summary.

joyceg’s picture

joyceg commented
Assigned: Unassigned » joyceg
Status: Needs review » Active

I am taking up this issue.

joyceg’s picture

joyceg commented
StatusFileSize
new PermissionSpell-2618222-3.patch881 bytes
joyceg’s picture

joyceg commented
Status: Active » Needs review
alan d.’s picture

alan d. commented
Status: Needs review » Needs work

needs update scripts. et al, so not just a trivial typo fix. maybe defer till D8?

naveenvalecha’s picture

naveenvalecha
He/Him
commented

great start joy, we also need an hook_update_n, you can read about it from here https://api.drupal.org/api/drupal/modules%21system%21system.api.php/func...

alan d.’s picture

alan d. commented
Category: Bug report » Task

Switching to a task as nothing is actually broken here. And probably happier to defer this to the 8.x branch.

naveenvalecha’s picture

naveenvalecha
He/Him
commented
Parent issue: » #2705075: Search Configuration 7.x-1.2
naveenvalecha’s picture

naveenvalecha
He/Him
commented
Status: Needs work » Needs review
StatusFileSize
new 2618222-9.patch1.39 KB
new interdiff-2618222-3-9.txt541 bytes

Here we go.Added hook_update.

naveenvalecha’s picture

naveenvalecha
He/Him
commented
Assigned: joyceg » Unassigned

Need review on it.

naveenvalecha’s picture

naveenvalecha
He/Him
commented

@Alan D,
Would you provide your thoughts ? are you happy with the patch so that we can commit it to 7.x

alan d.’s picture

alan d. commented

Really just background noise for users, but no issues if pushed.

How does this affect the migration of the permissions from D7 to D8?

naveenvalecha’s picture

naveenvalecha
He/Him
commented

How does this affect the migration of the permissions from D7 to D8?

It will not affect b/c we will use the updated permissions b/c as per our plan we will create another stable release soon before drupal 8 stable release.

Really just background noise for users, but no issues if pushed.

is it RTBC ?

Naveen

naveenvalecha’s picture

naveenvalecha
He/Him
commented
Status: Needs review » Fixed

Alright tested on local and all looks good.
Committing and pushed to 7.x-1.x

  • naveenvalecha committed ed48da4 on 7.x-1.x 
    Issue #2618222 by naveenvalecha, joyceg, Alan D.: permission spelled...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.