Right now every submodule creates its own test base class and duplicates createEntity() and assertFieldValues().

So let's create a CommerceTestBase that places blocks, contains those two methods.

CommentFileSizeAuthor
#12 commercetestbase_cleanup-2617638-12.patch1.38 KBvasike
#9 interdiff-2617638-7-9.txt2.47 KBvasike
#9 create_a_commercetestbase-2617638-9.patch19.01 KBvasike
#7 create_a_commercetestbase-2617638-7.patch16.53 KBvasike
#5 create_a_commercetestbase-2617638-5.patch14.49 KBmglaman
#3 interdiff-2617638-2-3.txt3.63 KBmglaman
#3 create_a_commercetestbase-2617638-3.patch16.85 KBmglaman
#2 commerce_test_base_implementation-2617638-2.patch14.95 KBvasike

Comments

bojanz created an issue. See original summary.

vasike’s picture

vasike
Location Ramnicu Valcea
commented
Status: Active » Needs review
StatusFileSize
new commerce_test_base_implementation-2617638-2.patch14.95 KB

there is patch for this:
- Implement CommerceTestBase
- Update OrderTestBase.php / ProductTestBase.php / StoreTestBase.php & EntitySelectWidgetTest.php to use this new test base class.

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
StatusFileSize
new create_a_commercetestbase-2617638-3.patch16.85 KB
new interdiff-2617638-2-3.txt3.63 KB

Here's an updated patch that provides permissions and adminUser helper.

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
Status: Needs review » Needs work

This no longer applies.

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
Status: Needs work » Needs review
StatusFileSize
new create_a_commercetestbase-2617638-5.patch14.49 KB

Rerolled to match HEAD. PR https://github.com/commerceguys/commerce/pull/294

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
Status: Needs review » Needs work

PR failing.

vasike’s picture

vasike
Location Ramnicu Valcea
commented
Status: Needs work » Needs review
StatusFileSize
new create_a_commercetestbase-2617638-7.patch16.53 KB

Here is a reroll of the previous patch/PR
+ Some "cleanup" for StoreTestBase and EntitySelectWidgetTest on using CommerceTestBase.

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented

Updated PR with patch from #7 https://github.com/drupalcommerce/commerce/pull/294

vasike’s picture

vasike
Location Ramnicu Valcea
commented
StatusFileSize
new create_a_commercetestbase-2617638-9.patch19.01 KB
new interdiff-2617638-7-9.txt2.47 KB

There are new Tests for Currency - #2615398: Create tests for currencies, let's include them in the patch.

  • bojanz committed e874c12 on 8.x-2.x authored by vasike 
    Issue #2617638 by vasike, mglaman: Create a CommerceTestBase
bojanz’s picture

bojanz commented
Status: Needs review » Fixed

Committed, thanks!

vasike’s picture

vasike
Location Ramnicu Valcea
commented
Status: Fixed » Needs review
StatusFileSize
new commercetestbase_cleanup-2617638-12.patch1.38 KB

patch with some cleanup for previous commit

bojanz’s picture

bojanz commented
Status: Needs review » Fixed

Committed.

  • bojanz committed 99055d9 on 8.x-2.x authored by vasike 
    Issue #2617638 followup by vasike: Clean up CommerceTestBase

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.