If you embed the Site Name content type containing an ampersand (e.g., "Crate & Barrel"), and configure it to link to the home page, the ampersand will be escaped.

This is because we first escape the site name with filter_xss_admin(), and then again in when creating the link with l().

Since the title is already escaped, we should not escape it when creating a link.

CommentFileSizeAuthor
#2 ctools-double-escaped-site-name-2616754-2.patch585 bytesjoelstein

Comments

joelstein created an issue. See original summary.

joelstein’s picture

joelstein commented
Status: Active » Needs review
StatusFileSize
new ctools-double-escaped-site-name-2616754-2.patch585 bytes
carsonw’s picture

carsonw
handsome / brilliant
commented
Status: Needs review » Reviewed & tested by the community

This patch is being used on dozens of sites and works as advertised.

rivimey’s picture

rivimey
she/her
commented
Parent issue: » #2828925: Plan for CTools 7.x-1.13 release

Propose for 1.13 release.

japerry’s picture

japerry
Location KOMK
commented
Status: Reviewed & tested by the community » Fixed

Simple enough. Committed!

  • japerry committed 65b7121 on 7.x-1.x authored by joelstein 
    Issue #2616754 by joelstein: Cannot display ampserand in site name...
joelstein’s picture

joelstein commented

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.