on the path_condition_info() the last labels is misspelled. The code is:

    'workflow_ng_condition_alias_exists' => array(
      '#label' => t('URL alias exists)'),
      '#module' => 'Path',

when it should be:

    'workflow_ng_condition_alias_exists' => array(
      '#label' => t('URL alias exists'),
      '#module' => 'Path',
CommentFileSizeAuthor
#5 workflow_ng_path.patch348 bytesavpaderno
#2 workflow_ng_path.inc_.patch101 bytesavpaderno

Comments

fago’s picture

fago
Primary language German
Location Vienna
commented

thanks, could you create a patch?

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Assigned: Unassigned » avpaderno
Category: bug » task
Status: Active » Needs review
StatusFileSize
new workflow_ng_path.inc_.patch101 bytes

Done.

amitaibu’s picture

amitaibu
Primary language Hebrew
Location Israel
commented
Status: Needs review » Needs work

Hi Kiam,
This patch doesn't look right.
You should follow this - http://drupal.org/patch/create

In short, use this code diff -upN original_directory new_directory > filename.patch in your cygwin installation.

Basically I could do it myself, but it's probably better for you to learn so we have another active member in the wf_ng area :)
If you need help let me know.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented

I guess I should have created a patch for the full directory containing the module files, and not the patch for the single file.
I need a different program to do that, then; WinMerge does not create patches for full directories.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Needs work » Needs review
StatusFileSize
new workflow_ng_path.patch348 bytes
amitaibu’s picture

amitaibu
Primary language Hebrew
Location Israel
commented
Status: Needs review » Reviewed & tested by the community

Tested by eye - seems to be ok. setting to RTBC.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Title: workflow_ng_path.inc shows a misspelled label » workflow_ng_path.inc doesn't use title case links
fago’s picture

fago
Primary language German
Location Vienna
commented
Status: Reviewed & tested by the community » Fixed

to be accurate, the patch should be created for the whole modules' directory.

But anyhow, I know where to find the path.inc .. thanks, committed. :)

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.