Both source and target languages seem to be the same in the HTML file export.

CommentFileSizeAuthor
#7 tmgmt_file_html_export_to_remote_target_language-2615796-7.patch1.03 KBmpp
#2 tmgmt_file_html_export_to_remote_target_language-2615796-1.patch723 bytesmpp

Comments

mpp created an issue. See original summary.

mpp’s picture

mpp commented
Assigned: mpp » Unassigned
Status: Active » Fixed
StatusFileSize
new tmgmt_file_html_export_to_remote_target_language-2615796-1.patch723 bytes
berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Fixed » Needs review

You need to set patches to needs review, not fixed.

Status: Needs review » Needs work

The last submitted patch, 2: tmgmt_file_html_export_to_remote_target_language-2615796-1.patch, failed testing.

mpp’s picture

mpp commented

Not sure why the tests would fail over a missing link when only the target language has been fixed?

fail: [Browser] Line 415 of modules/tmgmt/translators/tmgmt_file/src/Tests/FileTranslatorTest.php:
Link Review does not exist on http://localhost/checkout/admin/tmgmt/jobs/1

berdir’s picture

berdir
Primary language German
Location Switzerland
commented

The form submission fails with Failed to validate file, import aborted.

The problem is that the validate method has the same bug, should work once you update that.

mpp’s picture

mpp commented
Issue summary: View changes
StatusFileSize
new tmgmt_file_html_export_to_remote_target_language-2615796-7.patch1.03 KB

Indeed, updated the template and the validate method.

mpp’s picture

mpp commented
Status: Needs work » Needs review

The last submitted patch, 2: tmgmt_file_html_export_to_remote_target_language-2615796-1.patch, failed testing.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented

Thanks, committed.

  • Berdir committed 53e0989 on 8.x-1.x authored by mpp 
    Issue #2615796 by mpp: Wrong target language for html export in file...
mpp’s picture

mpp commented
Status: Needs review » Closed (fixed)

Great, thanks!