Convert hook_help to use routes

Hi pferlito,
Thanks for noticing this and producing a patch. I'll test it.
Jonathan

Attempt to see if D.O. testing runs now that the test branch is merged into Master.

Tested and it works.

However, did you notice that the link which is generated for the content-type list using Url::fromRoute('entity.node_type.collection') results in /admin/config/content/scheduler when it should be /admin/structure/types. I know this was not your change, and at the time we probably did not have the means to test it. But it needs to be fixed. How do we find out the conversions of Url::fromRoute to url values?

Thanks for getting this going, and making the patch. We always give credit to patch providers so will certainly do so here.

Thank you, yes that works. I must learn more about the routes.
Interesting that your file actually contain two separate patches (as I know them) the original intact and your second change separately. Is this another standard way to supply patches?

I've set to 'needs review' just to see if our automated testing copes with this style of patch. I know the tests will fail as we've not completed #2594615: Automated testing in 8.x [meta] yet, but I'd like to see if they at least start.

Well, looking at the test result log on https://dispatcher.drupalci.org/job/default/45734/console is seems there was no problem in applying the patch file. I can't tell if it applied one or both "patches" as neither of them would affect the current state of the tests, but usually if a patch file is not in a usable format you get a message and the testing process is halted.

There's no need for you to provide a new consolidated patch, I can use what you've given. But before I commit, I'd like my co-maintainer to take a quick review of your code. It all looks OK to me, and certainly the main fault is resolved, and the three parts of the help are now displayed as expected. Thanks for doing this.

Actually I've just noticed that in the dblog after applying your patches we get:

Recoverable fatal error: Argument 2 passed to scheduler_help() must be an instance of RouteMatchInterface,
instance of Drupal\Core\Routing\CurrentRouteMatch given in scheduler_help()
(line 53 of /Library/WebServer/Documents/drupal8/modules/scheduler/scheduler.module).

Looking at the example on the change notice on https://www.drupal.org/node/2250345 we need to add

use Drupal\Core\Routing\RouteMatchInterface;

Doing this removes the error.

Here's a single patch with everything from the above.

Patch needed a re-roll due to other commits. Tested each of the three help outputs - all OK. We do not have tests for this, but I don't think we need any, as it is static functionality and not much can go wrong.

I think this is good to go. Any objections?

As expected, did not alter the branch test results.

Thank you pferlito for your work on this. Committed and fixed.

You are welcome to take a look at our other issues currently blocking the first 8.x release #2662476: Progress towards 8.x release of Scheduler and your help would be appreciated :-)

Ignore the failed patch above. It was queued but not run until the 8.x committed codebase passed all tests. That happened with my commit a few minutes ago, and then the untested patches have suddenly come to life and been run. This issue is already fixed and closed.