We have to add vertical tabs in the form alter for the Field API to cooperate. However it was added after a logic check which cuts out earlier if the alter is running during AJAX. That means changes to "Choose discount type" return fields without the vertical tabs via AJAX. Incoming patch to fix.

CommentFileSizeAuthor
#2 choose_discount_type-2615160-2.patch1.69 KBmglaman

Comments

mglaman created an issue. See original summary.

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
Status: Active » Needs review
StatusFileSize
new choose_discount_type-2615160-2.patch1.69 KB

This fixes it! Now any AJAX calls that rebuild form keep those items in the vertical tabs. Discovered when working on #2599944: Move discount status to a vertical tab.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Needs review » Fixed

Fixed and committed to -dev. Thanks @mglaman

  • joelpittet committed 6e27b46 on 7.x-1.x authored by mglaman 
    Issue #2615160 by mglaman: Choose discount type resets vertical tabs

Status: Fixed » Needs work

The last submitted patch, 2: choose_discount_type-2615160-2.patch, failed testing.

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
Status: Needs work » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.