The generic EntityType condition has a very confusing name and is missing config schema

Thanks, keeping this issue open for now, I'l try to provide a patch to rename things.

Here's a patch, some explanation in next ocmment.

1. +++ b/src/Plugin/Condition/EntityBundle.php
   @@ -57,11 +54,10 @@ class EntityType extends ConditionPluginBase implements ConstraintConditionInter
   -  public function __construct(EntityManagerInterface $entity_manager, array $configuration, $plugin_id, $plugin_definition) {
   +  public function __construct(EntityTypeManagerInterface $entity_type_manager, EntityTypeBundleInfoInterface $entity_type_bundle_info, array $configuration, $plugin_id, $plugin_definition) {
        parent::__construct($configuration, $plugin_id, $plugin_definition);
   -    $this->entityStorage = $entity_manager->getStorage($this->getDerivativeId());
   -    $this->bundleType = $entity_manager->getDefinition($this->getDerivativeId());
   -    $this->bundleOf = $entity_manager->getDefinition($this->bundleType->getBundleOf());
   +    $this->entityTypeBundleInfo = $entity_type_bundle_info;
   +    $this->bundleOf = $entity_type_manager->getDefinition($this->getDerivativeId());
   

   Using the new services. Also bundleType is no longer needed.

2. +++ b/src/Plugin/Condition/EntityBundle.php
   @@ -122,10 +119,10 @@ class EntityType extends ConditionPluginBase implements ConstraintConditionInter
          $bundles = implode(', ', $bundles);
   -      return $this->t('The @entity_type @bundle_type is @bundles or @last', array('@entity_type' => strtolower($this->bundleOf->getLabel()), '@bundle_type' => strtolower($this->bundleType->getLabel()), '@bundles' => $bundles, '@last' => $last));
   +      return $this->t('@bundle_type is @bundles or @last', array('@bundle_type' => $this->bundleOf->getBundleLabel(), '@bundles' => $bundles, '@last' => $last));
        }
        $bundle = reset($this->configuration['bundles']);
   -    return $this->t('The @entity_type @bundle_type is @bundle', array('@entity_type' => strtolower($this->bundleOf->getLabel()), '@bundle_type' => strtolower($this->bundleType->getLabel()), '@bundle' => $bundle));
   +    return $this->t('@bundle_type is @bundle', array('@bundle_type' => $this->bundleOf->getBundleLabel(), '@bundle' => $bundle));
      }
    
      /**
   

   This part is tricky. Two problems:

   a) "@entity_type @bundle_type" IMHO leads to weird double names: "content content type" or "custom block custom block type". So I think just the bundle label is enough.

   b) lowercasing labels is problematic because that is only correct for english, in german, they have to stay uppercase. There are some pending issues around that. for the label, there's a special method but that actually has the same problem. it doesn't exist for bundle label, though. So I tried to leave out the The so that it can be at the beginning of the sentence. Not really sure about tha, maybe it could also be changed to not be a sentence but just "Node type: A, B or C" ?

3. +++ b/src/Plugin/Deriver/EntityBundle.php
   @@ -1,27 +1,28 @@
      public function getDerivativeDefinitions($base_plugin_definition) {
        foreach ($this->entityManager->getDefinitions() as $entity_type_id => $entity_type) {
   -      $bundle_of = $entity_type->getBundleOf();
   -      if ($bundle_of) {
   +      if ($entity_type->hasKey('bundle')) {
            $this->derivatives[$entity_type_id] = $base_plugin_definition;
   -        $this->derivatives[$entity_type_id]['label'] = $this->t('@label', ['@label' => $entity_type->getLabel()]);
   

   This changes the plugin ID from entity_bundle:node, so the bundle of node, which I think makes a lot more sense than entity_type:node_type, which sounds like it checks that the entity type is node_type?