Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Updated to https://modernizr.com/news/modernizr-3-2-0
| Comment | File | Size | Author |
|---|---|---|---|
| #17 | interdiff-2614682-17-11.txt | 344 bytes | miteshmap |
| #17 | update_js_lib-2614682-17.patch | 9.82 KB | miteshmap |
| #11 | update_js_lib-2614682-11.patch | 9.42 KB | lyalyuk |
Comments
Comment #2
nod_They added filtering to their for loop, no code change in the tests we're using.
Comment #4
droplet CreditAttribution: droplet commentedComment #6
droplet CreditAttribution: droplet commentedComment #7
xjmThanks for the update!
I believe since this is a minor version library update, it should be targeted for 8.1.x now as per https://www.drupal.org/core/d8-allowed-changes#minor.
Comment #8
alexpottI downloaded the library from Modernizr again and did a diff to the patch and it wasn't the same... not sure what is going on.
Comment #9
droplet CreditAttribution: droplet commentedI don't hijack it... [ just a joke :) ]
It's interesting. their builder using GIT master.
https://github.com/Modernizr/Modernizr/commit/695fd5ef3cad5b867785d5cff4...
Comment #10
droplet CreditAttribution: droplet commentedhttps://github.com/Modernizr/Modernizr/issues/1802
Comment #11
lyalyuk CreditAttribution: lyalyuk as a volunteer commentedModernizr setClasses is required in 3.3.0 and higher.
Need review
Comment #12
andypostComment #13
Trebor CreditAttribution: Trebor as a volunteer commentedPer #11, downloaded patch and applied it successfully in D8.0.3-dev, version is now 3.3.1 for Modernzr (modernizr.min.js), first line in modernizr.min.js reads
/*! modernizr 3.3.1 (Custom Build) | MIT *Comment #14
catchThis needs a libraries.yml change.
Comment #15
Trebor CreditAttribution: Trebor as a volunteer commentedAgreed, in the /core/core.libraries.yml file, line 824 still reads the old version: version: "v3.1.0"
Comment #16
miteshmapUpdated based on comments from @Trebor and @catch
Comment #17
miteshmapSorry! wrong patch... Updated new one..
Comment #18
Trebor CreditAttribution: Trebor as a volunteer commentedReviewed #16 (patch file update_js_lib-2614682-16.patch) and this one correctly updates the /core/core.libraries.yml file modernizr version to 3.3.1.
Note that #17 seems to be another patch to update the actual modernizr.min.js file. Some confusion here perhaps?
Comment #20
catch@Trebor #17 is the right patch - has both the library update and the libraries.yml change together.
Committed/pushed to 8.1.x, thanks! I don't think we should do this in 8.0.x unless there's a specific bug fix we need - please re-open if you think we should commit it to 8.0.x too.
Tagging for a release notes mention.
Comment #21
Trebor CreditAttribution: Trebor as a volunteer commentedThanks @catch for the clarification on the #17 patch.