Follow-up to #2097033-10: "cache-control's max-age header" and "The expires header":

The status report page will check for mod_headers by using the apache_get_modules() function. mod_expires isn't required from my tests but I could have been mistaken.

If I had more awareness of the different apache modules, I would have noticed, that I need to enable mod_headers (by reading <IfModule mod_headers.c> in .htaccess), but I didn't. Maybe we should improve the comments there?

The problem with using the apache_get_modules() is, that it won't work while using php as CGI/FastCGI (see: http://php.net/manual/en/function.apache-get-modules.php#100654).

So we could just leave a comment in .htaccess file or replace the function apache_get_modules() with something similar to wordpress' apache_mod_loaded().

CommentFileSizeAuthor
#2 advagg-htaccess-mod-headers-comment-2612082-2.patch2.67 KBosopolar

Comments

osopolar created an issue. See original summary.

osopolar’s picture

osopolar
Primary language German
Location 🇩🇪 GER 🌐
commented
StatusFileSize
new advagg-htaccess-mod-headers-comment-2612082-2.patch2.67 KB
osopolar’s picture

osopolar
Primary language German
Location 🇩🇪 GER 🌐
commented
Issue summary: View changes

  • mikeytown2 committed 86d3a63 on 7.x-2.x authored by osopolar 
    Issue #2612082 by osopolar: Make clear that for apache mod_headers or...
mikeytown2’s picture

mikeytown2 commented
Status: Needs review » Active

Committed a slightly modified version of #2. Keeping open so the wp apache_mod_loaded function can be used in advagg.

mikeytown2’s picture

mikeytown2 commented
Status: Active » Closed (duplicate)

Merging into #2606542: Adv CSS/JS Agg - Incorrect readings The request for a file was served by Drupal instead of the web server (like Apache).