The current code has two problems:
1) The column label logic was never ported, so the label/bundle columns are always called "Label" and "Type"
2) The label field doesn't invoke $entity->label(), therefore showing the wrong label when the entity has a label callback or any custom logic on the class itself.
3) The whole fallback to id only made sense in D7 cause many entity types didn't have labels in the beginning. In D8 all entity types have labels.
Solution:
Kill the id fallback, port the column label logic, introduce a special IEF field type that calls $entity->label().
Patch incoming.
| Comment | File | Size | Author |
|---|---|---|---|
| #34 | inline_entity_form-fix_tablefields_d7-2612070-34.patch | 2.27 KB | brockfanning |
Comments
Comment #2
bojanz commentedInitial patch attached.
Still running tests, they might need an update.
This fixes the issue I have with product variations, which don't have a label key, but have a label() which builds a label based on other fields.
Comment #8
bojanz commentedUpdated the tests, since the column is now always called "label", the classes changed.
Comment #14
bojanz commentedThird time's the charm.
I should mention my reasoning for making "label" always the key of the column, instead of using the label key when available:
When it comes to fields, labels are special because they might not be backed by an actual field, they might be dynamically generated.
The fixed column key emphasises this, as well as the fact that the source of the data is not a rendered field, but $entity->label() instead.
Comment #15
slashrsm commentedLooks good to me.
Comment #17
bojanz commentedCommitted. Thanks for the review.
Comment #33
bojanz commentedWhat the..
Comment #34
brockfanning commentedI'm still in D7-world, and needed this, so here is a patch to get #2 (in the issue description) working in D7.
Comment #43
brockfanning commentedComment #45
brockfanning commentedI don't know what's going on with the tests... But this is ready for review, in my opinion.
Comment #46
dcam commentedSince Drupal 7 is now end-of-life I am closing some old issues for the 7.x branch of this module. If this issue is still relevant for the 3.x branch of the module, then feel free to reopen it.