Problem/Motivation

Fields created via d6_vocabulary_field and d6_vocabulary_field_instance use their machine name as field name.

Proposed resolution

Use the same behaviour as in D6 (Vocabulary name as field name).

Remaining tasks

User interface changes

API changes

Data model changes

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

webflo created an issue. See original summary.

webflo’s picture

Status: Active » Needs review
Issue tags: +rc eligible
FileSize
638 bytes
webflo’s picture

FileSize
2 KB
webflo’s picture

Status: Needs review » Needs work

The last submitted patch, 4: 2612008-4-testonly.patch, failed testing.

webflo’s picture

Status: Needs work » Needs review
FileSize
2 KB

Patch from #3 again, because the last patch was a test only patch.

mikeryan’s picture

Status: Needs review » Needs work
+++ b/core/modules/taxonomy/src/Tests/Migrate/d6/MigrateVocabularyFieldInstanceTest.php
@@ -39,11 +40,13 @@ public function testVocabularyFieldInstance() {
+    $this->assertIdentical(Vocabulary::load('tags')->label(), $field->label());

It looks to me like this is testing that the instance label matches the field label - i.e., taking for granted that they are both populated from the same place (original vocabulary name). I think it would be better to test directly against the source data that's being migrated.

webflo’s picture

Status: Needs work » Needs review
FileSize
1.71 KB
mikeryan’s picture

Status: Needs review » Reviewed & tested by the community
webchick’s picture

Status: Reviewed & tested by the community » Fixed

Nice catch. Committed and pushed to 8.0.x. Thanks!

  • webchick committed 0c1be8a on 8.1.x
    Issue #2612008 by webflo: Add proper field labels for vocabulary fields
    

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.