Problem/Motivation

Fields created via d6_vocabulary_field and d6_vocabulary_field_instance use their machine name as field name.

Proposed resolution

Use the same behaviour as in D6 (Vocabulary name as field name).

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#8 2612008-8.patch1.71 KBwebflo
#6 2612008-3.patch2 KBwebflo
#4 2612008-4-testonly.patch1.37 KBwebflo
#3 2612008-3.patch2 KBwebflo
#2 2612008-2.patch638 byteswebflo

Comments

webflo created an issue. See original summary.

webflo’s picture

webflo commented
Status: Active » Needs review
Issue tags: +rc eligible
StatusFileSize
new 2612008-2.patch638 bytes
webflo’s picture

webflo commented
StatusFileSize
new 2612008-3.patch2 KB
webflo’s picture

webflo commented
StatusFileSize
new 2612008-4-testonly.patch1.37 KB

Status: Needs review » Needs work

The last submitted patch, 4: 2612008-4-testonly.patch, failed testing.

webflo’s picture

webflo commented
Status: Needs work » Needs review
StatusFileSize
new 2612008-3.patch2 KB

Patch from #3 again, because the last patch was a test only patch.

mikeryan’s picture

mikeryan
he/him
Primary language English
Location Pittsfield, MA, USA
commented
Status: Needs review » Needs work 
+++ b/core/modules/taxonomy/src/Tests/Migrate/d6/MigrateVocabularyFieldInstanceTest.php
@@ -39,11 +40,13 @@ public function testVocabularyFieldInstance() {
+    $this->assertIdentical(Vocabulary::load('tags')->label(), $field->label());

It looks to me like this is testing that the instance label matches the field label - i.e., taking for granted that they are both populated from the same place (original vocabulary name). I think it would be better to test directly against the source data that's being migrated.

webflo’s picture

webflo commented
Status: Needs work » Needs review
StatusFileSize
new 2612008-8.patch1.71 KB
mikeryan’s picture

mikeryan
he/him
Primary language English
Location Pittsfield, MA, USA
commented
Status: Needs review » Reviewed & tested by the community
webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Nice catch. Committed and pushed to 8.0.x. Thanks!

  • webchick committed 0c1be8a on 8.1.x 
    Issue #2612008 by webflo: Add proper field labels for vocabulary fields

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.