When a file of the same name, as the file being uploaded, already exists in either the public:// (original) files folder or the fe_paths destination folder the file will fail to move properly.

Incrementing of the file names is the default behavior of file uploads and this should be accounted for on the original upload and allowed to occur on the move.

CommentFileSizeAuthor
#4 fe_paths-duplicate-named-files_2611740_4.patch1.92 KBfrodri
#2 fe_paths-duplicate-named-files_2611740_2.patch1.96 KBkerby70

Comments

kerby70 created an issue. See original summary.

kerby70’s picture

kerby70 commented
StatusFileSize
new fe_paths-duplicate-named-files_2611740_2.patch1.96 KB

See attached patch.

sgdev’s picture

sgdev commented
Version: 7.x-2.0-alpha3 » 7.x-2.x-dev
Status: Needs review » Needs work

Seems as though this patch was created against 7.x-2.0-beta3 rather than 7.x-2.x-dev. Patches should always be created against the -dev version.

frodri’s picture

frodri commented
StatusFileSize
new fe_paths-duplicate-named-files_2611740_4.patch1.92 KB

Patch in #2 assumes the main module file is located in a sub-directory. I've attached a copy of that same patch with the correct directories set up.

sgdev’s picture

sgdev commented
Status: Needs work » Needs review

Agreed, and thanks for the update. Setting to review.