Add a warning for \Drupal:: use in OO code

Pushed a first version of this to throw warnings in classes that extend FormBase or ControllerBase. Further suggestions welcome!

It is interesting, because for me, the codesmell is mainly when its part of generic services, rather the controllers / forms, which are integration level code anyway.

Regrettably I think \Drupal::anything is going to be with us for a while.

Maybe a movement/attitude like the the one I am linking to.

Slowly we can beat the practice out of core.

Anyway just a suggestion.

Opened sister issue #2720343: Add a warning for global function use like t() in classes.

+1 on this idea. I doubt it will be in core's phpcs.xml.dist file any time soon, however. :-)

Nice!

Yeah I'm truely convinced that everytime you have to use \Drupal you have some sort of design flaw.
Random example: Entity classes should not contain logic, so often this logic should be totally separate and just change the entity object for example.

Yeah I'm truely convinced that everytime you have to use \Drupal you have some sort of design flaw.

:-)

I think we can call this fixed now. The sniff only reports on a subset of classes, but it is good enough as a start.