Problem/Motivation

You should be able to include custom script type attributes, e.g. "application/json" or "text/x-handlebars-template".

Proposed resolution

Only unset the script type attribute if it is "text/javascript".

CommentFileSizeAuthor
#3 only_remove_redundant-2608420-3.patch1.05 KBjtwalters
#2 only_remove_redundant-2608420-2.patch1022 bytesjtwalters

Comments

jtwalters created an issue. See original summary.

jtwalters’s picture

jtwalters commented
Status: Needs work » Needs review
StatusFileSize
new only_remove_redundant-2608420-2.patch1022 bytes

Here's a patch.

jtwalters’s picture

jtwalters commented
StatusFileSize
new only_remove_redundant-2608420-3.patch1.05 KB

Adding an isset check for avoiding PHP notices.

steinmb’s picture

steinmb commented

This is allow us to use the #attribute instead of resorting to drupa_add_js()? Sorry, I'm not a js developer.

jtwalters’s picture

jtwalters commented

This patch simply allows you to use a custom type attribute on a script tag/element. It doesn't matter how you add the script tag. Omega is being too opinionated about removing the type attribute.

BarisW’s picture

BarisW commented
Status: Needs review » Reviewed & tested by the community

Looks good!

This also enabled Omega themes to use the application/ld+json type.

tbenice’s picture

tbenice commented

Just endorsing getting this in a release. I have to do some hackity stuff to make this work for google social profiles (ld+json).

Thanks!

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Issue tags: +Schema.org Metatag
Related issues: +#2915542: Missing type="application/ld+json" on script tag when using Zen or Mothership or Adaptivetheme themes, +#2934644: Don't remove type="application/ld+json" in zen_process_html_tag()

FYI this is a useful fix for sites using Schema.org Metatag (schema_metatag).