in file: core/lib/Drupal/Core/StringTranslation/TranslatableMarkup.php. typo in doc comment block.

-   * Gets all argments from this translated string.
+   * Gets all arguments from this translated string.
CommentFileSizeAuthor
typo-TranslatableMarkup-1.patch537 bytesrakesh.gectcr

Comments

rakesh.gectcr created an issue. See original summary.

snehi’s picture

snehi commented

@rakesh.gectcr
Please use

issue number

in Patch file

typo-TranslatableMarkup-1.patch

For more info please find below format as an example for creating patch.

git diff 7.x-1.x > [project_name]-[short-description]-[issue-number]-[comment-number]-[drupal-version].patch
I hope this will not repeated again.

Thanks for the patch.

eojthebrave’s picture

eojthebrave
he/him
Primary language English
Location Minneapolis, MN
commented
Status: Needs review » Reviewed & tested by the community

The typo fix looks good to me. I didn't actually apply and test this locally but it's a super simple patch. While the patch name might not be ideal it'll still work fine. As far as I'm concerned this is good to go.

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.1.x and cherry-picked to 8.0.x, thanks!

  • catch committed 7ed8f51 on 8.1.x 
    Issue #2608056 by rakesh.gectcr: Comment Typo in TranslatableMarkup...

  • catch committed ddf3ceb on 
    Issue #2608056 by rakesh.gectcr: Comment Typo in TranslatableMarkup...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.