Server support for Drupal 8 shipped config across projects (contributed modules)

Marking critical and parenting to #2559711: [meta] Drupal.org (websites/infra) blockers to Drupal 8.0.0, 8.1.0, etc. now.

So I rolled out potx updates to l.d.o due to other fixes and without this integration code, it fatals out and does not work at all. :/ I *think* we need this minimal code to make them work together for now.

Rolled this out for now. That seems to work for now as a hotfix.

I tested this by building out shipped-localize.dev.devdrupal.org, clicking 'Start over' for the latest release at https://shipped-localize.dev.devdrupal.org/admin/l10n_server/projects/re..., and running cron.

The attached patch changes:

• Whitespace and trailing-comma-in-array cleanups.
• Put a full copy of the schema in l10n_drupal_update_7100(). Update functions should have a snapshot of the schema at that point in time, and l10n_drupal_schema() will change in the future.
• l10n_drupal_parsed_module_data's pid column wasn't actually used. I removed it and made the primary key module_name.
• db_merge() needs values to be serialized before they go in.

To do:

• I see l10n_drupal_parsed_module_data's module_version column exists, but is not used. If it should be used, I expect it will go in the table's primary key. Otherwise, remove it.
• Could be an artifact of my testing, but I didn't see parsed_schema get populated at all.
• I think _l10n_drupal_schema_load() should fall back to the potx default if it doesn't have the processed schema in the DB. We won't be parsing the D8 projects in any particular order, so there will be plenty of things parsed before their dependencies. This manifests as:
  

  array_merge(): Argument #2 is not an array potx.inc:2694
  array_merge(): Argument #2 is not an array potx.inc:2695
  array_merge(): Argument #2 is not an array potx.inc:2696
  array_merge(): Argument #2 is not an array potx.inc:2697
  array_merge(): Argument #1 is not an array potx.inc:2694
  array_merge(): Argument #1 is not an array potx.inc:2695
  array_merge(): Argument #1 is not an array potx.inc:2696
  array_merge(): Argument #1 is not an array potx.inc:2697
  in_array() expects parameter 2 to be array, null given potx.inc:2300
  in_array() expects parameter 2 to be array, null given potx.inc:2301
  in_array() expects parameter 2 to be array, null given potx.inc:2300
  in_array() expects parameter 2 to be array, null given potx.inc:2301
  in_array() expects parameter 2 to be array, null given potx.inc:2300
  in_array() expects parameter 2 to be array, null given potx.inc:2301
  in_array() expects parameter 2 to be array, null given potx.inc:2300
  in_array() expects parameter 2 to be array, null given potx.inc:2301
  in_array() expects parameter 2 to be array, null given potx.inc:2300
  in_array() expects parameter 2 to be array, null given potx.inc:2301

Looks good. I still don't have anything stored in parsed_schema, but maybe I haven't parsed an interesting module yet. I do see the fixes should improve it.

I recommend also removing l10n_drupal_schema_reverse_lookup's unused lid column. The primary key can be either array('schema_key') or array('schema_key', 'module_name'), depending on whether schema_key is unique or not. The module_name column should be shortened to 'length' => '255'. This will let the SELECT queries hit a key, and we won't have a potentially confusing ID that doesn't match up to anything else.

I wanted to help figure out the version number. The dev site does not have the original drupal.org passwords. I requested a new password (multiple times) but the email did not arrive. Finally I tried to ssh in as explained in https://www.drupal.org/node/1018084 but that is asking for a local password (which I don't believe I have, I use ssh keys to log in to d.o servers).

From IRC - I got Gábor's SSH access fixed and confirmed the dev site is on potx fd41357.

Have you had a chance to look through this from #11?

I recommend also removing l10n_drupal_schema_reverse_lookup's unused lid column. The primary key can be either array('schema_key') or array('schema_key', 'module_name'), depending on whether schema_key is unique or not. The module_name column should be shortened to 'length' => '255'. This will let the SELECT queries hit a key, and we won't have a potentially confusing ID that doesn't match up to anything else.

The same patch, now with DrupalCI testing enabled for the project.

DrupalCI's full console output includes:

Specified key was too long; max key length is 767 bytes

An index on each column, without a primary key, will be okay for this table.

This patch replaces that primary key with the two indexes.

That patch was incomplete, I missed the added file.

A dev site with the latest dev version of potx and @Drumm's patch applied to l10n_server is available here: https://potx-localize-localize.dev.devdrupal.org/

+++ b/connectors/l10n_drupal/l10n_drupal.potx.inc
@@ -0,0 +1,174 @@
+ * Initialize potx to run locally, e.g. by drush.
+ *
+ * @param string $module_path
+ *   Path to the module that is being parsed by potx.
+ */
+function _l10n_drupal_potx_init() {

All these docs look incorrect based on the code.

BTW otherwise the patch looks fine to me.

Yay, thanks! Committed this one, looking into deploying it.

Add deployment tag. Will do this tomorrow.

I believe this was deployed to production.

Yes it was, thanks!